Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HealthCheckExecutionHistory update in case of whole service is down. #893

Open
som-nitjsr opened this issue Jan 17, 2022 · 0 comments
Open
Labels

Comments

@som-nitjsr
Copy link

som-nitjsr commented Jan 17, 2022

Please, fill the following sections to help us fix the issue

I am using the health check for .Net core api and I am using latest health check package.
I am facing issue with HealthCheckExecutionHistory history.
If i use the as per the sample

 .AddCheck(name: "random", () =>
                {
                    return DateTime.UtcNow.Second % 2 == 0 ? HealthCheckResult.Healthy() : HealthCheckResult.Unhealthy();
                })

This service returns both Healthy and unhealthy status. and i can see the entry in exection histry and sma eon the UI.

But in My services I am using

.AddCheck(name: "random", () =>
                {
                    return HealthCheckResult.Healthy() ;
                })

which will return healthy if my service is up and running.
and in case of service failure UI client will get request failure instead of unhealthy json response.
in this case UI client will not add history entry and only show Unhealthy status.
I want history to be maintained in case of whole service service.
Is there any thing I am missing?

@sungam3r sungam3r added the UI label Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants