Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding sqlite package is exposing AddOracle Method #2203

Closed
thompson-tomo opened this issue Apr 28, 2024 · 0 comments · Fixed by #2271
Closed

Adding sqlite package is exposing AddOracle Method #2203

thompson-tomo opened this issue Apr 28, 2024 · 0 comments · Fixed by #2271
Assignees

Comments

@thompson-tomo
Copy link

Please, fill the following sections to help us fix the issue

What happened:
When i added HealthChecks.Sqlite package to my project i gained an AddOracle extension method

What you expected to happen:
Only have gained AddSqlite methods.

How to reproduce it (as minimally and precisely as possible):

  1. Install Package
  2. Type in services.AddHealthChecks()
  3. Now view the extension methods

Source code sample:
services.AddHealthChecks().AddOracle()

Anything else we need to know?:
Might need to leave wrong interface and deprecate/obsolete it to avoid breaking changes.

Environment:

n/a

@Alirexaa Alirexaa self-assigned this Jul 29, 2024
@Alirexaa Alirexaa linked a pull request Jul 31, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants