MinimumSecondsBetweenFailureNotifications settings may not work for SQLite storage

[digrizzz]

What happened:

WebHookFailureNotifier.IsNotifiedOnWindowTimeAsync() doesn't work correct with SQLite storage because of .ToLower() call inside query:

        private async Task<bool> IsNotifiedOnWindowTimeAsync(string livenessName, bool restore)
        {
#pragma warning disable RCS1155 // Use StringComparison when comparing strings.
            var lastNotification = await _db.Failures
                .Where(lf => lf.HealthCheckName.ToLower() == livenessName.ToLower())
                .OrderByDescending(lf => lf.LastNotified)
                .Take(1)
                .SingleOrDefaultAsync();
#pragma warning restore RCS1155 // Use StringComparison when comparing strings.

            return lastNotification != null
                &&
                lastNotification.IsUpAndRunning == restore
                &&
                (DateTime.UtcNow - lastNotification.LastNotified).TotalSeconds < _settings.MinimumSecondsBetweenFailureNotifications;
        }

What you expected to happen:

WebHookFailureNotifier.IsNotifiedOnWindowTimeAsync works correct

How to reproduce it (as minimally and precisely as possible):

• use SQLite storage sample
• set huge MinimumSecondsBetweenFailureNotifications (e.g. 3600)
• add faulty healthcheck with name "АбВг" (e.g. which is always fail)
• define webhook notification
• notification will appear more often then expected 3600 seconds

Anything else we need to know?:

"related" issue in ef core repo: dotnet/efcore#27378

• .NET Core version: .net7
• Healthchecks version: 6.0.5
• Operative system: Win10
• Others:

[digrizzz]

my proposing solution: https://sqlite.org/forum/forumpost/d2f7daf09ea920e9

[sungam3r]

PR is welcome.