Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from legacy "Microsoft.IdentityModel.Clients.ActiveDirectory" (ADAL) to "Microsoft.Identity.Client" (MSAL) #1363

Closed
Kiechlus opened this issue Jul 28, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@Kiechlus
Copy link

What would you like to be added:

We found out that KeyVault checks (and possibly others) still use the deprecated ADAL authentication library.

Why is this needed:

We are currently investigating SSL Heartbleed issues and detected that ADAL is using System.Security.Cryptography.OpenSsl version 4.3.0 from 2016. We are not sure if this is causing the issue, but it is still quite old. The new MSAL does not contain this package (tested on .Net 6).

@sungam3r
Copy link
Collaborator

PR is welcome.

@sungam3r sungam3r added the enhancement New feature or request label Jul 30, 2022
@Kiechlus
Copy link
Author

Kiechlus commented Aug 1, 2022

I don't even understand why this package is needed. I checked all files in the HealthChecks.AzureKeyVault namespace on master and don't find any reference to that package.

@WillemRB
Copy link
Contributor

Both Microsoft.Azure.Services.AppAuthentication and Microsoft.IdentityModel.Clients.ActiveDirectory aren't needed in the project.

@sungam3r
Copy link
Collaborator

@Kiechlus I see no Microsoft.IdentityModel.Clients.ActiveDirectory references in master. Please try the latest preview packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants