Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about NuGet/setup-nuget #1048

Closed
sungam3r opened this issue Mar 27, 2022 · 1 comment · Fixed by #1062
Closed

Question about NuGet/setup-nuget #1048

sungam3r opened this issue Mar 27, 2022 · 1 comment · Fixed by #1062

Comments

@sungam3r
Copy link
Collaborator

I see that each CD workflow uses

  - name: setup nuget
      uses: NuGet/setup-nuget@v1.0.5
      env:
        ACTIONS_ALLOW_UNSECURE_COMMANDS: 'true'
      with:
        nuget-version: latest

After that it executes

 - name: Publish <NAME_HERE> Health Check nuget
      run: dotnet nuget push ./artifacts/AspNetCore.HealthChecks.NAME.*.nupkg -k ${{secrets.NUGET_API_KEY}} -s https://api.nuget.org/v3/index.json --skip-duplicate

but dotnet nuget push is a built-in dotnet CLI command. So why to bother with setup nuget step in all CD workflows?
ping @carlosrecuero @unaizorrilla

@sungam3r
Copy link
Collaborator Author

sungam3r commented Apr 1, 2022

@carlosrecuero Also I suggest to get rid of --include-source --include-symbols in all pack commands. With embedded PDBs and SourceLink all that jumping over "debugger options" is unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant