Merge remote-tracking branch 'XRPLF/ximinez/lending-refactoring-4' into ximinez/lending-XLS-66

* XRPLF/ximinez/lending-refactoring-4:
  fixup! Rename Transactor preflight functions
  Rename Transactor preflight functions
  fixup! Make preflight1 and preflight2 private static Transactor functions
  Make preflight1 and preflight2 private static Transactor functions
  Fix formatting

Author: ximinez

src/test/app/AMM_test.cpp

@@ -7485,7 +7485,8 @@ struct AMM_test : public jtx::AMMTest
 
         auto const testCase = [&](std::string suffix, FeatureBitset features) {
             testcase("Fail pseudo-account allocation " + suffix);
-            Env env{*this, features};
+            std::string logs;
+            Env env{*this, features, std::make_unique<CaptureLogs>(&logs)};
             env.fund(XRP(30'000), gw, alice);
             env.close();
             env(trust(alice, gw["USD"](30'000), 0));

src/xrpld/app/main/Application.cpp

@@ -305,8 +305,8 @@ class ApplicationImp : public Application, public BasicApp
                       static_cast<int>(std::thread::hardware_concurrency());
 
                   // Be more aggressive about the number of threads to use
-                  // for the job queue if the server is configured as "large"
-                  // or "huge" if there are enough cores.
+                  // for the job queue if the server is configured as
+                  // "large" or "huge" if there are enough cores.
                   if (config->NODE_SIZE >= 4 && count >= 16)
                       count = 6 + std::min(count, 8);
                   else if (config->NODE_SIZE >= 3 && count >= 8)

src/xrpld/app/tx/detail/Transactor.cpp

@@ -120,7 +120,8 @@ preflightCheckSimulateKeys(
 {
     if (flags & tapDRY_RUN)  // simulation
     {
-        if (!sigObject.getFieldVL(sfTxnSignature).empty())
+        std::optional<Slice> const signature = sigObject[~sfTxnSignature];
+        if (signature && !signature->empty())
         {
             // NOTE: This code should never be hit because it's checked in the
             // `simulate` RPC
@@ -144,7 +145,8 @@ preflightCheckSimulateKeys(
             }
         }
 
-        if (!sigObject.getFieldVL(sfSigningPubKey).empty())
+        Slice const signingPubKey = sigObject[sfSigningPubKey];
+        if (!signingPubKey.empty())
         {
             // trying to single-sign _and_ multi-sign a transaction
             return temINVALID;