Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get latest tag (not tag associated with latest commit) #32

Merged
merged 17 commits into from
Oct 24, 2022

Conversation

bakoontz2
Copy link
Contributor

No description provided.

@bakoontz2
Copy link
Contributor Author

See #31.

@WyriHaximus
Copy link
Owner

@bakoontz2 Just merged #33 to make sure we're running the latest actions/checkout version which should provide the tags. Could you rebase those changes in?

@WyriHaximus WyriHaximus added this to the v1.2.0 milestone Sep 11, 2022
@WyriHaximus
Copy link
Owner

Also just merged #34 which adds testing to ensure the outputs will output something and otherwise fail the pipeline.

@bakoontz2
Copy link
Contributor Author

This is great, thanks! So what do you need me to do? (Sorry, don't work much with github PRs...)

@WyriHaximus
Copy link
Owner

This is great, thanks! So what do you need me to do? (Sorry, don't work much with github PRs...)

Right so first add this repository as a remote:

git remote add upstream https://github.com/WyriHaximus/github-action-get-previous-tag.git

Then fetch from that remote:

git fetch upstream 

And then rebase:

git rebase -i upstream/master

@WyriHaximus
Copy link
Owner

Sorry, don't work much with github PRs...

Don't be, I gladly help out with any questions you might have 😃 .

@bakoontz2
Copy link
Contributor Author

Ah, that makes sense. Done.

@WyriHaximus
Copy link
Owner

Thanks! (Didn't fully work out as expected, but it should be fine once merged.) Any clue why the tests are failing, it seems it isn't picking up the tag it should pick up?

@bakoontz2
Copy link
Contributor Author

bakoontz2 commented Sep 18, 2022

It's not really clear what is going on here: So the PR is running my CI tests?

At any rate, there were two issues: (1) Tags aren't copied over to forked repos by default. I had to do a git fetch --tags upstream; git push --tags. This fixed the previoustag failure. (2) There is no longer an error generated when there are no tags to be fetched. Code now checks for empty return value for tags after checking for errors. This fixed the previoustagwithfallback error.

The CI tests are returning successfully now.

@WyriHaximus WyriHaximus merged commit 67f0cb1 into WyriHaximus:master Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants