-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get latest tag (not tag associated with latest commit) #32
Conversation
See #31. |
…s-checkout-to-v3 Bump GitHub Actions checkout to v3
@bakoontz2 Just merged #33 to make sure we're running the latest |
Fail on empty outputs
Also just merged #34 which adds testing to ensure the outputs will output something and otherwise fail the pipeline. |
This is great, thanks! So what do you need me to do? (Sorry, don't work much with github PRs...) |
Right so first add this repository as a remote: git remote add upstream https://github.com/WyriHaximus/github-action-get-previous-tag.git Then fetch from that remote: git fetch upstream And then rebase: git rebase -i upstream/master |
Don't be, I gladly help out with any questions you might have 😃 . |
Ah, that makes sense. Done. |
Thanks! (Didn't fully work out as expected, but it should be fine once merged.) Any clue why the tests are failing, it seems it isn't picking up the tag it should pick up? |
It's not really clear what is going on here: So the PR is running my CI tests? At any rate, there were two issues: (1) Tags aren't copied over to forked repos by default. I had to do a The CI tests are returning successfully now. |
No description provided.