Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: ESM Support #361

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

WIP: ESM Support #361

wants to merge 5 commits into from

Conversation

matthewnitschke-wk
Copy link

Adds support for esm modules

@aviary-wf
Copy link

aviary-wf commented Jun 15, 2023

Security Insights

The items listed below may not capture all security relevant changes. Before providing a security review, be sure to review the entire PR for security impact.

(4) Security relevant changes were detected
  • Watched keyword dangerouslySetInnerHTML in dist/react_with_react_dom.esm.js line(s) ['7901', '8752', '8754', '8954', '8956', '8960', '8963', '8966', '8968', '12437', '21888', '23433', '24314'] added
  • Watched keyword dangerouslysetinnerhtml in dist/react_with_react_dom.esm.js line(s) ['22875'] added
  • Watched keyword dangerouslySetInnerHTML in lib/react_with_react_dom.esm.js line(s) ['5503', '6354', '6356', '6556', '6558', '6562', '6565', '6568', '6570', '10039', '19490', '21035', '21916'] added
  • Watched keyword dangerouslysetinnerhtml in lib/react_with_react_dom.esm.js line(s) ['20477'] added
  • Action Items

    • Obtain a security review; reviewer should pay special attention to insights listed above
    • Verify aviary.yaml coverage of security relevant code

    Questions or Comments? Reach out on Slack: #support-infosec.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants