Clean code and fix issues reported by staticcheck #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
sarroutbi
force-pushed
the
202305251644_clean_code
branch
4 times, most recently
from
498236a
to
e5b6f40
Compare
|
Any chance this PR could be reviewed? |
|
@sarroutbi Wondering the same about my own PR. The project seems pretty dead to me. |
dustinhiatt-wf
previously approved these changes
Sep 27, 2023
matthinrichsen-wf
requested changes
Sep 27, 2023
| @@ -412,7 +412,7 @@ func TestNodeSplit(t *testing.T) { | |||
|
|
|||
| rt, err = mutable.Commit() | |||
| require.NoError(t, err) | |||
| rt, err = Load(cfg.Persister, rt.ID(), comparator) | |||
There was a problem hiding this comment.
Can we require.NoError here instead of underscoring?
btree/immutable/rt_test.go
Outdated
| @@ -504,7 +504,7 @@ func TestRandom(t *testing.T) { | |||
|
|
|||
| require.NoError(t, err) | |||
| expected := toOrdered(items).toItems() | |||
| result, err := mutable.(*Tr).toList(itemsToValues(expected...)...) | |||
| result, _ := mutable.(*Tr).toList(itemsToValues(expected...)...) | |||
There was a problem hiding this comment.
Same here:
Can we require.NoError here instead of underscoring?
btree/immutable/rt_test.go
Outdated
| @@ -762,7 +762,7 @@ func TestSecondCommitMultipleSplits(t *testing.T) { | |||
| mutable := rt.AsMutable() | |||
| mutable.AddItems(items[:25]...) | |||
| mutable.(*Tr).verify(mutable.(*Tr).Root, t) | |||
| rt, err := mutable.Commit() | |||
| rt, _ = mutable.Commit() | |||
There was a problem hiding this comment.
Here as well:
Can we require.NoError here instead of underscoring?
sarroutbi
force-pushed
the
202305251644_clean_code
branch
from
e5b6f40
to
1da9ed0
Compare
Signed-off-by: Sergio Arroutbi <sarroutb@redhat.com>
sarroutbi
force-pushed
the
202305251644_clean_code
branch
from
1da9ed0
to
a69ce3b
Compare
|
Hello @matthinrichsen-wf . Can you please check, when possible, if this PR can be merged after your recommendations? Thanks !!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.