Skip to content

Commit 5bc6b88

Browse files
committed
GH Actions: limit the use of MySQL 8.0 to PHP 7.4 or higher
... as based on the test output, there are issues in WP Core which prevent the tests from being run against MySQL 8.0 using PHP 7.3 or lower. These issues have been reported upstream. See: https://core.trac.wordpress.org/ticket/52496
1 parent 122fdc2 commit 5bc6b88

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

.github/workflows/test.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,11 @@ jobs:
109109
# See: https://core.trac.wordpress.org/ticket/34692
110110
# WP 5.4 is the first WP version which largely supports MySQL 8.0.
111111
# See: https://core.trac.wordpress.org/ticket/49344
112-
image: mysql:${{ ( matrix.wp < 4.5 && '5.6' ) || ( matrix.wp < 5.4 && '5.7' ) || '8.0' }}
112+
# During the setting up of these tests, it became clear that MySQL 8.0
113+
# in combination with PHP < 7.4 is not properly/sufficiently supported
114+
# within WP Core.
115+
# See: https://core.trac.wordpress.org/ticket/52496
116+
image: mysql:${{ ( matrix.wp < 4.5 && '5.6' ) || ( (matrix.wp < 5.4 || matrix.php < 7.4) && '5.7' ) || '8.0' }}
113117
env:
114118
MYSQL_ALLOW_EMPTY_PASSWORD: false
115119
ports:

0 commit comments

Comments
 (0)