Replace inline event handler in wp-admin/theme-editor.php and wp-admin/plugin-editor.php with event handler in js/_enqueues/wp/theme-plugin-editor.js.

Author: enricocarraro

src/js/_enqueues/wp/theme-plugin-editor.js

@@ -81,6 +81,24 @@ wp.themePluginEditor = (function( $ ) {
 				component.docsLookUpButton.prop( 'disabled', false );
 			}
 		} );
+
+		component.docsLookUpButton.on( 'click', function () {
+			if ( '' != component.docsLookUpList.val() ) {
+				window.open(
+					'https://api.wordpress.org/core/handbook/1.0/?function=' +
+						encodeURIComponent( component.docsLookUpList.val() ) +
+						'&locale=' +
+						encodeURIComponent(
+							window.themePluginEditorL10n.locale
+						) +
+						'&version=' +
+						encodeURIComponent(
+							window.themePluginEditorL10n.wpVersion
+						) +
+						'&redirect=true'
+				);
+			}
+		} );
 	};
 
 	/**

src/wp-admin/plugin-editor.php

@@ -271,8 +271,8 @@
 		<div id="documentation" class="hide-if-no-js">
 			<label for="docs-list"><?php _e( 'Documentation:' ); ?></label>
 			<?php echo $docs_select; ?>
-			<input disabled id="docs-lookup" type="button" class="button" value="<?php esc_attr_e( 'Look Up' ); ?>" onclick="if ( '' != jQuery('#docs-list').val() ) { window.open( 'https://api.wordpress.org/core/handbook/1.0/?function=' + escape( jQuery( '#docs-list' ).val() ) + '&amp;locale=<?php echo urlencode( get_user_locale() ); ?>&amp;version=<?php echo urlencode( get_bloginfo( 'version' ) ); ?>&amp;redirect=true'); }" />
-		</div>
+			<input disabled id="docs-lookup" type="button" class="button" value="<?php esc_attr_e( 'Look Up' ); ?>" />
+	</div>
 	<?php endif; ?>
 
 	<?php if ( is_writable( $real_file ) ) : ?>

src/wp-admin/theme-editor.php

@@ -292,7 +292,7 @@
 			<div id="documentation" class="hide-if-no-js">
 				<label for="docs-list"><?php _e( 'Documentation:' ); ?></label>
 				<?php echo $docs_select; ?>
-				<input disabled id="docs-lookup" type="button" class="button" value="<?php esc_attr_e( 'Look Up' ); ?>" onclick="if ( '' != jQuery('#docs-list').val() ) { window.open( 'https://api.wordpress.org/core/handbook/1.0/?function=' + escape( jQuery( '#docs-list' ).val() ) + '&amp;locale=<?php echo urlencode( get_user_locale() ); ?>&amp;version=<?php echo urlencode( get_bloginfo( 'version' ) ); ?>&amp;redirect=true'); }" />
+				<input disabled id="docs-lookup" type="button" class="button" value="<?php esc_attr_e( 'Look Up' ); ?>" />
 			</div>
 		<?php endif; ?>
 

src/wp-includes/script-loader.php

@@ -1040,6 +1040,14 @@ function wp_default_scripts( $scripts ) {
 	$scripts->add( 'code-editor', "/wp-admin/js/code-editor$suffix.js", array( 'jquery', 'wp-codemirror', 'underscore' ) );
 	$scripts->add( 'wp-theme-plugin-editor', "/wp-admin/js/theme-plugin-editor$suffix.js", array( 'common', 'wp-util', 'wp-sanitize', 'jquery', 'jquery-ui-core', 'wp-a11y', 'underscore' ) );
 	$scripts->set_translations( 'wp-theme-plugin-editor' );
+	$scripts->localize(
+		'wp-theme-plugin-editor',
+		'themePluginEditorL10n',
+		array(
+			'locale'    => get_user_locale(),
+			'wpVersion' => get_bloginfo( 'version' ),
+		)
+	);
 
 	$scripts->add( 'wp-playlist', "/wp-includes/js/mediaelement/wp-playlist$suffix.js", array( 'wp-util', 'backbone', 'mediaelement' ), false, 1 );
 
@@ -1077,7 +1085,7 @@ function wp_default_scripts( $scripts ) {
 	$scripts->set_translations( 'user-profile' );
 
 	$scripts->add( 'language-chooser', "/wp-admin/js/language-chooser$suffix.js", array( 'jquery' ), false, 1 );
-	
+
 	$scripts->add( 'setup-config', "/wp-admin/js/setup-config$suffix.js", array(), false, 1 );
 
 	$scripts->add( 'user-suggest', "/wp-admin/js/user-suggest$suffix.js", array( 'jquery-ui-autocomplete' ), false, 1 );