Skip to content

Implement opt-in PERFLAB_PLACE_OBJECT_CACHE_DROPIN for Server-Timing object-cache.php placement #1996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

b1ink0
Copy link
Contributor

@b1ink0 b1ink0 commented Apr 28, 2025

Summary

Fixes #1633

Relevant technical choices

Introduce PERFLAB_PLACE_OBJECT_CACHE_DROPIN constant to opt-in to placing the Server-Timing object-cache.php drop-in.

@b1ink0 b1ink0 added [Type] Enhancement A suggestion for improvement of an existing feature [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only labels Apr 28, 2025
@b1ink0 b1ink0 added this to the performance-lab n.e.x.t milestone Apr 28, 2025
Copy link

codecov bot commented Apr 28, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.51%. Comparing base (ff8b62b) to head (d228f28).

Files with missing lines Patch % Lines
plugins/performance-lab/load.php 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            trunk    #1996      +/-   ##
==========================================
- Coverage   72.51%   72.51%   -0.01%     
==========================================
  Files          85       85              
  Lines        7023     7025       +2     
==========================================
+ Hits         5093     5094       +1     
- Misses       1930     1931       +1     
Flag Coverage Δ
multisite 72.51% <50.00%> (-0.01%) ⬇️
single 40.34% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider alternative to using object-cache drop-in to implement early Server-Timing
1 participant