Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add end-to-end test that verifies RTL on all critical path pages #625

Closed
1 task
sarayourfriend opened this issue Feb 1, 2022 · 0 comments
Closed
1 task

Add end-to-end test that verifies RTL on all critical path pages #625

sarayourfriend opened this issue Feb 1, 2022 · 0 comments
Labels
♿️ aspect: a11y Concerns related to the project's accessibility 🧰 goal: internal improvement Improvement that benefits maintainers, not users help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend 🟨 tech: javascript Involves JavaScript

Comments

@sarayourfriend
Copy link
Contributor

Problem

It is too easy to merge a PR that breaks RTL for a whole page. For example, the homepage's RTL is broken in WordPress/openverse-frontend#765.

Description

Let's add an E2E test that compares the RTL and LTR pages and verifies that the dir attribute is set appropriately.

We don't need to test the content of the pages, mostly just that the dir attribute is set. As long as we're writing our tailwind using the RTL utility classes we should be good.

Implementation

  • 🙋 I would be interested in implementing this feature.
@sarayourfriend sarayourfriend added good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟨 tech: javascript Involves JavaScript labels Feb 1, 2022
@krysal krysal added ♿️ aspect: a11y Concerns related to the project's accessibility and removed good first issue New-contributor friendly 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🤖 aspect: dx Concerns developers' experience with the codebase labels Feb 21, 2022
@obulat obulat transferred this issue from WordPress/openverse-frontend Feb 22, 2023
@obulat obulat added the 🧱 stack: frontend Related to the Nuxt frontend label Feb 22, 2023
@obulat obulat closed this as completed Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
♿️ aspect: a11y Concerns related to the project's accessibility 🧰 goal: internal improvement Improvement that benefits maintainers, not users help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend 🟨 tech: javascript Involves JavaScript
Projects
Openverse Backlog
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@krysal @obulat @sarayourfriend