Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move search type path part computation into searchStore #597

Closed
1 task
sarayourfriend opened this issue Mar 17, 2022 · 1 comment
Closed
1 task

Move search type path part computation into searchStore #597

sarayourfriend opened this issue Mar 17, 2022 · 1 comment
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed

Comments

@sarayourfriend
Copy link
Contributor

Problem

We evaluate the current pattern in a few places to build the frontend search path: searchType.value === ALL_MEDIA ? '' : searchType.value.

Description

We could just move this into the search store to prevent having to evaluate this in several different places.

Depends on the search store being merged in WordPress/openverse-frontend#1040

Implementation

  • 🙋 I would be interested in implementing this feature.
@sarayourfriend sarayourfriend added good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Mar 17, 2022
@sarayourfriend sarayourfriend mentioned this issue Mar 17, 2022
Merged
7 tasks
@obulat obulat transferred this issue from WordPress/openverse-frontend Feb 22, 2023
@obulat
Copy link
Contributor

obulat commented Feb 24, 2023

This issue has already been solved.

@obulat obulat closed this as completed Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed
Projects
Openverse Backlog
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@obulat @sarayourfriend