Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected url from Provider link in Single result view #560

Open
1 task
fcoveram opened this issue May 12, 2022 · 6 comments
Open
1 task

Unexpected url from Provider link in Single result view #560

fcoveram opened this issue May 12, 2022 · 6 comments
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend

Comments

@fcoveram
Copy link
Contributor

fcoveram commented May 12, 2022

Description

Clicking the provider link on the audio metadata information takes you to the track page on the provider rather than the provider's main page. Reported by @sarayourfriend

Reproduction

  1. Search anything.
  2. Open one result to see the single result view.
  3. Click on the provider's name in the Audio information area.
  4. It opens the audio link instead of the source site's homepage.

Solution

We will need to read from the provider store inside of these components and switch from using the image's foreign landing URL to using the source URL of the provider.

Resolution

  • 🙋 I would be interested in resolving this bug.
@fcoveram fcoveram added 🟩 priority: low Low priority and doesn't need to be rushed 🛠 goal: fix Bug fix 🕹 aspect: interface Concerns end-users' experience with the software labels May 12, 2022
@krysal
Copy link
Member

krysal commented May 12, 2022

This made sense to me in the audio view because the main button was for downloads, there wasn't a "Go to the audio's website" button/link but also it's the same behavior in the image view. Personally, I think is fine this way but I understand there can create confusion. What do you think @panchovm?

@fcoveram
Copy link
Contributor Author

As more I think of this, I believe we need to switch to "Go to the content site" button for all content. This because we will start integrating the search engine in core, and because it solves the friction we might have with providers on redirecting user traffic.

@krysal krysal added good first issue New-contributor friendly help wanted Open to participation from the community labels Aug 17, 2022
@obulat
Copy link
Contributor

obulat commented Dec 13, 2022

@panchovm , do we need to change the provider link to link to the provider's main page for this issue? So, for this screenshot, the "Science Museum - UK" should link to the home page of the Science Museum "https://www.sciencemuseum.org.uk/home"? Or maybe we need to link to the page of the open collections on the provider ("https://collection.sciencemuseumgroup.org.uk/")?
Screenshot 2022-12-13 at 9 00 18 AM

@fcoveram
Copy link
Contributor Author

I am drawn to link the source homepage as the field shows the source name. Landing on a collection page also makes sense, but in this case, the section mentions the organization responsible for the content.

Since the link opens an external site, we should add the external icon.

Note that this change is in line with allowing entry points to see source results in Openverse, an idea we have discussed before. But for that case, it seems better to replace the "Related images" heading with actions going to related content, content from same author, content from same source, content in collections, and so on.

@obulat obulat transferred this issue from WordPress/openverse-frontend Feb 22, 2023
@obulat obulat added the 🧱 stack: frontend Related to the Nuxt frontend label Feb 22, 2023
@obulat
Copy link
Contributor

obulat commented Oct 21, 2023

We have updated the source and provider links to link to the main sites of the providers or the sources.

However, now it is confusing for items with sources that are different from providers.

For instance, this image is from SpaceX as source, and Flickr as provider. Source links to the SpaceX main page because that is the link that we have in Django admin for the SpaceX source.

I think we should link to the homepage of the open media collection of the provider and the open media collection page of the source.

So, for a SpaceX image, I would prefer to link to https://www.flickr.com/people/spacex/ for source and https://flickr.com for provider.
For Smithsonian images, for instance Stage Design by Angelo Toselli, to link to https://collection.cooperhewitt.org/ (instead of the current https://www.cooperhewitt.org/) as source and https://www.si.edu/search/collection-images for provider (currently, we don't have a record for Smithsonian at all in Django admin.

@fcoveram
Copy link
Contributor Author

I agree it's confusing

I think we should link to the homepage of the open media collection of the provider and the open media collection page of the source.

Very much agree with this. The link should open the collection landing page in the provider site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend
Projects
Status: 📋 Backlog
Development

No branches or pull requests

3 participants