Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set airflow user password in DDL from environment #1695

Open
1 task
AetherUnbound opened this issue Oct 20, 2021 · 0 comments
Open
1 task

Set airflow user password in DDL from environment #1695

AetherUnbound opened this issue Oct 20, 2021 · 0 comments
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users good first issue New-contributor friendly help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: catalog Related to the catalog and Airflow DAGs 🔧 tech: airflow Involves Apache Airflow 💾 tech: postgres Involves PostgreSQL

Comments

@AetherUnbound
Copy link
Contributor

Current Situation

Our current DDL implementation uses the default password airflow always: https://github.com/WordPress/openverse-catalog/blob/d5d39f1ab65a7f3fcf72b04efa336bedd2c690a5/docker/local_postgres/0001_airflow_user_db.sql.
This can cause a potential security issue when deploying a production instance for the first time.

Suggested Improvement

Alter the first script to pull the password from an environment variable (possible solution here).

Benefit

This would allow us to define a different environment variable when running this migration on production, with a default for when running on dev.

Alternatives

Add explicit warnings in documentation or a guide for how to run deployments.

Additional context

This will be influenced and possibly covered by #1836.

Implementation

  • 🙋 I would be interested in implementing this feature.
@AetherUnbound AetherUnbound added 🟨 priority: medium Not blocking but should be addressed soon 🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Oct 20, 2021
@AetherUnbound AetherUnbound added good first issue New-contributor friendly help wanted Open to participation from the community 💾 tech: postgres Involves PostgreSQL labels Feb 2, 2022
@obulat obulat added the 🧱 stack: catalog Related to the catalog and Airflow DAGs label Feb 24, 2023
@AetherUnbound AetherUnbound added the 🔧 tech: airflow Involves Apache Airflow label Mar 20, 2023
@obulat obulat transferred this issue from WordPress/openverse-catalog Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users good first issue New-contributor friendly help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: catalog Related to the catalog and Airflow DAGs 🔧 tech: airflow Involves Apache Airflow 💾 tech: postgres Involves PostgreSQL
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants