Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "openledger" to either catalog or API #1546

Open
1 task
AetherUnbound opened this issue May 24, 2022 · 1 comment
Open
1 task

Rename "openledger" to either catalog or API #1546

AetherUnbound opened this issue May 24, 2022 · 1 comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: catalog Related to the catalog and Airflow DAGs 🔧 tech: airflow Involves Apache Airflow 💾 tech: postgres Involves PostgreSQL 🐍 tech: python Involves Python

Comments

@AetherUnbound
Copy link
Contributor

Description

We currently have a number of references to openledger in this codebase, mainly in reference to our databases. While changing the name of the database from openledger would be a non-trivial effort, we should rename instances of openledger to either catalog or api. For instance, OPENLEDGER_CONN_ID can become CATALOG_CONN_ID. References to the API could change too once WordPress/openverse-catalog#513 is introduced.

Additional context

Implementation

  • 🙋 I would be interested in implementing this feature.
@AetherUnbound AetherUnbound added 🐍 tech: python Involves Python 🔧 tech: airflow Involves Apache Airflow 🟩 priority: low Low priority and doesn't need to be rushed 🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels May 24, 2022
@AetherUnbound AetherUnbound mentioned this issue May 25, 2022
Merged
7 tasks
@dhruvkb
Copy link
Member

dhruvkb commented May 26, 2022

A similar issue might need to be opened in WordPress/openverse-api because there are a number of references to openledger as the DB name in the codebase.

@krysal krysal mentioned this issue Oct 7, 2022
Open
29 tasks
@AetherUnbound AetherUnbound added the 💾 tech: postgres Involves PostgreSQL label Oct 7, 2022
@AetherUnbound AetherUnbound mentioned this issue Feb 22, 2023
Open
1 task
@obulat obulat added the 🧱 stack: catalog Related to the catalog and Airflow DAGs label Feb 24, 2023
@obulat obulat transferred this issue from WordPress/openverse-catalog Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: catalog Related to the catalog and Airflow DAGs 🔧 tech: airflow Involves Apache Airflow 💾 tech: postgres Involves PostgreSQL 🐍 tech: python Involves Python
Projects
Openverse Backlog
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AetherUnbound @obulat @dhruvkb