Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Further improve Release docs #9925

Merged
merged 2 commits into from
Oct 17, 2018
Merged

docs: Further improve Release docs #9925

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da863c9
docs: Further improve Release docs
tofumatt Sep 14, 2018
f305227
docs: Tidy up headers
tofumatt Sep 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
docs: Further improve Release docs 
Includes proposal of a new versioning scheme and more accurate representation
of the release candidate process.
  • Loading branch information
@tofumatt
tofumatt committed Sep 14, 2018
commit da863c94b97d03cc9c937f22e73c49b85876fbda
9 changes: 1 addition & 8 deletions bin/build-plugin-zip.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,19 +44,12 @@ if [ ! -z "$changed" ]; then
exit 1
fi

branch="$(git rev-parse --abbrev-ref HEAD)"
if [ "$branch" != 'master' ]; then
warning "WARNING: You should probably be running this script against the
'master' branch (current: '$branch')"
sleep 2
fi

# Do a dry run of the repository reset. Prompting the user for a list of all
# files that will be removed should prevent them from losing important files!
status "Resetting the repository to pristine condition. ✨"
git clean -xdf --dry-run
warning "🚨 About to delete everything above! Is this okay? 🚨"
echo -n "[Y]es/[N]o: "
echo -n "[y]es/[N]o: "
Copy link
Member

@gziolo gziolo Oct 17, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be lowercase for N, too? :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No is the default, so it's uppercase 😄

read answer
if [ "$answer" != "${answer#[Yy]}" ]; then
# Remove ignored files to reset repository to pristine condition. Previous
Expand Down
2 changes: 1 addition & 1 deletion docs/reference/deprecated.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Gutenberg's deprecation policy is intended to support backwards-compatibility for two minor releases, when possible. The current deprecations are listed below and are grouped by _the version at which they will be removed completely_. If your plugin depends on these behaviors, you must update to the recommended alternative before the noted version.
Copy link
Member

@aduth aduth Apr 1, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this supposed to be removed without a replacement? It currently reads awkwardly as "intended to support compatibility for releases". I don't think it should have been removed.

Edit: I propose adding back in #14756

Gutenberg's deprecation policy is intended to support backwards-compatibility for releases, when possible. The current deprecations are listed below and are grouped by _the version at which they will be removed completely_. If your plugin depends on these behaviors, you must update to the recommended alternative before the noted version.

## 4.0.0

Expand Down
Binary file added docs/reference/release-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading