Fix Meta boxes saving when they’re not present #67254
Merged
+43
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stokesman
added
[Feature] Meta Boxes
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -44 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
|
Thanks for the PR! I can't review this PR now because I haven't yet been able to reproduce the issue, but the approach looks reasonable. This PR ensures that |
afercia
reviewed
Nov 25, 2024
packages/edit-post/src/components/meta-boxes/use-meta-box-initialization.js
Outdated
Show resolved
Hide resolved
|
@stokesman thanks for looking into this. I quickly tested it and it does fix #67207 Seems a better approach than #67228 To my understanding: While the presentation in the UI of the meta boxes will be still controlled by hasAnyVisible >
instead, the functionality and thus the POST request will be controlled by this new check, which only checks whether there is a metabox in a location, regardless of whether it's active in the preferences. Is that correct? |
It will not only when none of the locations have any meta boxes. If the "side" location has a meta box and the "normal" or "advanced" do not then
Correct 🎯 |
|
Flaky tests detected in db46c07. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12015860595
|
stokesman
commented
Nov 25, 2024
t-hamano
approved these changes
Nov 29, 2024
Mamaduka
reviewed
Nov 29, 2024
packages/edit-post/src/components/meta-boxes/use-meta-box-initialization.js
Outdated
Show resolved
Hide resolved
cbravobernal
added
the
Backport to WP Minor Release
|
@t-hamano, @stokesman I tried to do a cherry-pick to the I don't have the context to decide what should be in 6.7 branch vs trunk right now. Can you please take a look? Otherwise it will take some time to understand everything 😅 |
|
It looks like the only thing that needs kept from this branch in those conflicted sections is: useMetaBoxInitialization( hasActiveMetaboxes );I’ve made #67503 as such. I’ve yet to manually test it but I’ll do so now. UPDATE: That PR works well but while testing I realized this PR had introduced a separate regression. Now meta boxes don’t hide/show as intended. I have #67504 open to fix trunk. |
stokesman
commented
Dec 3, 2024
| isEditorReady: __unstableIsEditorReady(), | ||
| }; | ||
| }, | ||
| [ location ] |
There was a problem hiding this comment.
This dependency should not have been removed 🤦♂️.
stokesman
commented
Dec 3, 2024
| [ location ] | ||
| const metaBoxes = useSelect( | ||
| ( select ) => | ||
| select( editPostStore ).getMetaBoxesPerLocation[ location ] |
There was a problem hiding this comment.
Should be a function call getMetaBoxesPerLocation( location ). Bummer this was missed as it seems to break hiding/showing of the meta boxes.
im3dabasia
pushed a commit
to im3dabasia/gutenberg
that referenced
this pull request
Dec 4, 2024
* Initialize meta boxes whether or not they’re visible * Add hook for initialization of meta boxes * Minimize hook for meta boxes initialization * Name the export Co-authored-by: stokesman <presstoke@git.wordpress.org> Co-authored-by: afercia <afercia@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: enricobattocchi <lopo@git.wordpress.org>
michalczaplinski
pushed a commit
that referenced
this pull request
Dec 5, 2024
* Initialize meta boxes whether or not they’re visible * Add hook for initialization of meta boxes * Minimize hook for meta boxes initialization * Name the export Co-authored-by: stokesman <presstoke@git.wordpress.org> Co-authored-by: afercia <afercia@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: enricobattocchi <lopo@git.wordpress.org>
|
I compared the code with the ´wp/6.7´ and both are the same except from ´enablePaddingAppender´. Which doesn't exist on that branch. I can consider this PR backported, but please @stokesman confirm if we need anything else. |
cbravobernal
removed
the
Backport to WP Minor Release
Yes, nothing else should be needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Ensures meta boxes are saved even if none of their areas are present in the Post editor’s UI.
Fixes #67207. Alternative to #67228 (or possibly a follow up to it).
Why?
Besides fixing a bug, this makes the meta box initialization more explicit/visible. It’s also a small optimization by invoking an effect in fewer places and executing less code when meta boxes aren’t present.
It seems more sensible this way because the initialization of all meta boxes is not really a responsibility of a component that represents only a single area of meta boxes.
How?
MetaBoxescomponentLayoutcomponentTesting Instructions
open the Yoast SEO sidebar and change a setting, e.g. the focus keyphrase