Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip: do not add the aria-describedby attribute to the anchor #66021

Draft
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

ciampo
Copy link
Contributor

@ciampo ciampo commented Oct 10, 2024

What?

With the changes from this PR, the Tooltip component does not add the aria-describedby attribute to its anchor.

Why?

As discussed in #65888 (and many other places), the Tooltip component currently can add the aria-describedby attribute to its anchor, thus providing an accessible description for the anchor element.

This approach is problematic for a few reasons:

  • it can provide redundant information in case the anchor already had an accessible description, or a label that was informative enough (this was in part mitigated in Tooltip: add aria-describedby to anchor only if not redundant #65989);
  • the accessible description is only available when the tooltip is visible, meaning that it can change dynamically — which can be disruptive to assistive technology users.

It was therefore decided that tooltips should be assumed to be decorative only, and that anchors using a tooltip should make sure they have an accessible label and description regardless of potential tooltips.

How?

  • Deleting code. The underlying ariakit component already doesn't add the aria-describedby attribute.

TODO

  • Create a list of components that need reviewing
  • Create accessibility guidelines
  • Divide and conquer

Testing Instructions

For any tooltip usage, make sure that when the tooltip is shown, there are no changes to the aria-describedby attribute on the anchor.

@ciampo
Copy link
Contributor Author

ciampo commented Oct 10, 2024

I've started this effort early in the 6.8 release cycle, so that we have as much time as possible to iterate over the whole repo and merge the change.

I'd like for this to be a collaborative effort. Here is what we could do:

  1. Find a way to list all usages of <Tooltip /> (similar to Button: Replace remaining 40px default size violations #65018). I guess the majority may come from either the Tooltip component itself, or the Button component;
  2. Once we have identified all usages, we can start tackling them one by one (or group by group). We could open a PR, branched off this PR, that makes the necessary changes to tooltip anchors to make sure they are still accessibly labelled and described;
  3. We can merge the PRs into the current PR;
  4. Once all migrations are done, we can merge this PR.

@WordPress/gutenberg-components @afercia @t-hamano @joedolson what do y'all think?

@t-hamano
Copy link
Contributor

Thank you for starting to address this issue! I agree with the approach you proposed.

Find a way to list all usages of <Tooltip />

Do we need to search our entire code for some kind of regex pattern? If so, the pattern I can come up with is something like this:

  • <Tooltip
  • text={
  • toggleProps

@mirka
Copy link
Member

mirka commented Oct 10, 2024

Just so we don't forget — noting that this PR also needs to add good accessibility guidance in the relevant component docs.

@tyxla
Copy link
Member

tyxla commented Oct 11, 2024

Thank you for proposing this solution, I agree it makes sense, and I always appreciate us leaning on the clean / simple side of things.

Could be a good opportunity to involve a broader group of contributors, just like we did for #65018.

@ciampo ciampo force-pushed the fix/remove-tooltip-aria-describedby branch from 1da779b to 4f7530a Compare October 11, 2024 13:25
@ciampo
Copy link
Contributor Author

ciampo commented Oct 11, 2024

I started adding some initial temporary ESLint rules for the most obvious usages — here is a list of the matches:

Here is a list of the matches
/packages/block-directory/src/components/downloadable-block-list-item/index.js
  104:3  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  104:3  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/block-alignment-matrix-control/index.js
  36:6  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/block-card/index.js
  54:5  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/block-edit-visually-button/index.js
  30:4  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/block-full-height-alignment-control/index.js
  15:3  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/block-heading-level-dropdown/index.js
  50:3  error  ToolbarDropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/block-lock/toolbar.js
  49:5  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/block-mover/button.js
  131:5  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  131:5  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/block-mover/index.js
  89:7  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/block-navigation/dropdown.js
  29:3  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/block-parent-selector/index.js
  75:4  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/block-pattern-setup/setup-toolbar.js
  37:3  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  45:3  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  68:4  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  75:4  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/block-patterns-list/index.js
  31:10  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  31:10  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/block-patterns-paging/index.js
  40:7  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  51:7  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  76:7  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  87:7  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/block-settings-menu/block-settings-dropdown.js
  221:6  error  DropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/block-styles/index.js
  69:7  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/block-switcher/index.js
  293:5  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  324:6  error  DropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed   no-restricted-syntax

/packages/block-editor/src/components/block-toolbar/shuffle.js
  20:4  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/block-tools/zoom-out-mode-inserter-button.js
  15:3  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/block-tools/zoom-out-toolbar.js
   94:7  error  Button needs to be checked to make sure it has an accessible description if needed                      no-restricted-syntax
  123:5  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/block-variation-picker/index.js
  44:7  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/block-variation-transforms/index.js
  38:5  error  Button needs to be checked to make sure it has an accessible description if needed                     no-restricted-syntax
  77:3  error  DropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/border-radius-control/input-controls.js
  71:6  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  71:6  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/border-radius-control/linked-button.js
  12:3  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  12:3  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  13:4  error  Button needs to be checked to make sure it has an accessible description if needed                no-restricted-syntax

/packages/block-editor/src/components/color-style-selector/index.js
  64:5  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/convert-to-group-buttons/toolbar.js
   86:4  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
   92:5  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
   99:5  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  106:5  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/duotone-control/index.js
  55:6  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/global-styles/shadow-panel-components.js
  83:3  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  83:3  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/grid/grid-item-movers.js
  167:4  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/image-editor/aspect-ratio-dropdown.js
  76:3  error  DropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/image-editor/form-controls.js
  16:4  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  19:4  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/image-editor/rotation-button.js
  17:3  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/image-editor/zoom-dropdown.js
  26:5  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/inserter/block-patterns-explorer/pattern-explorer-sidebar.js
  17:6  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/inserter/block-patterns-tab/patterns-filter.js
  106:4  error  DropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/inserter/media-tab/media-preview.js
   52:3  error  DropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  271:8  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed       no-restricted-syntax
  271:8  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed       no-restricted-syntax

/packages/block-editor/src/components/inserter/quick-inserter.js
  141:5  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/inspector-controls-tabs/index.js
  57:8  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  57:8  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/inspector-popover-header/index.js
  33:6  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  46:6  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/link-control/index.js
  411:11  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/link-control/link-preview.js
  147:5  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  154:6  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  161:5  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/media-placeholder/index.js
  56:7  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/media-replace-flow/index.js
  145:5  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/rich-text/format-toolbar/index.js
  45:9  error  DropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/rich-text/toolbar-button.js
  26:4  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/spacing-sizes-control/input-controls/spacing-input-control.js
  332:5  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/spacing-sizes-control/linked-button.js
  22:3  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  22:3  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  23:4  error  Button needs to be checked to make sure it has an accessible description if needed                no-restricted-syntax

/packages/block-editor/src/components/tabbed-sidebar/index.js
  31:6  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/tool-selector/index.js
  46:5  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/url-input/button.js
  43:5   error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  57:8   error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  69:11  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/url-popover/image-url-input-ui.js
  273:6  error  Button needs to be checked to make sure it has an accessible description if needed                      no-restricted-syntax
  302:6  error  Button needs to be checked to make sure it has an accessible description if needed                      no-restricted-syntax
  318:4  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/url-popover/index.js
  88:8  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/url-popover/link-editor.js
  38:4  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/url-popover/link-viewer.js
  40:5  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/url-popover/stories/index.story.js
  44:7  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/components/warning/index.js
  35:9  error  DropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-editor/src/hooks/content-lock-ui.js
  56:5  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-library/src/block/edit.js
  147:7  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  157:7  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-library/src/button/edit.js
  314:6  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  323:6  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-library/src/embed/embed-controls.js
  36:6  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-library/src/file/edit.js
  54:3  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-library/src/freeform/convert-to-blocks-button.js
  20:3  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-library/src/freeform/modal.js
  27:3  error  Button needs to be checked to make sure it has an accessible description if needed                      no-restricted-syntax
  94:6  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-library/src/gallery/edit.js
  622:6  error  ToolbarDropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-library/src/group/placeholder.js
  167:8  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-library/src/html/edit.js
  47:6  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  53:6  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-library/src/image/image.js
  598:7  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  605:7  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  616:7  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  632:8  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  688:9  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-library/src/list-item/edit.js
  53:4  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  60:4  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-library/src/list/edit.js
  110:4  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  147:4  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  156:4  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-library/src/media-text/edit.js
  443:7  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  451:7  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-library/src/navigation-link/edit.js
  462:6   error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  473:7   error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  496:8   error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed        no-restricted-syntax
  496:8   error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed        no-restricted-syntax
  548:10  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed        no-restricted-syntax
  548:10  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed        no-restricted-syntax

/packages/block-library/src/navigation-submenu/edit.js
  361:7  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  373:6  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-library/src/navigation/edit/index.js
  593:9  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-library/src/navigation/edit/leaf-more-menu.js
  117:3  error  DropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-library/src/navigation/edit/navigation-menu-selector.js
  141:3  error  DropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-library/src/navigation/edit/responsive-wrapper.js
   81:5  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  103:7  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-library/src/page-list/edit.js
  359:7  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-library/src/paragraph/edit.js
  34:4  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-library/src/post-date/edit.js
  148:11  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-library/src/query/edit/query-toolbar.js
  23:6  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-library/src/search/edit.js
  377:6  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed        no-restricted-syntax
  387:6  error  ToolbarDropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  393:7  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed        no-restricted-syntax

/packages/block-library/src/site-logo/edit.js
  336:6  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-library/src/social-link/edit.js
  84:9  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-library/src/social-links/edit.js
  165:5  error  ToolbarDropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-library/src/table-of-contents/edit.js
  92:5  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-library/src/table/edit.js
  467:7  error  ToolbarDropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-library/src/template-part/edit/index.js
  245:8  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-library/src/utils/caption.js
  79:6  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-library/src/video/edit.js
  234:10  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/block-library/src/video/tracks-editor.js
   60:6  error  Button needs to be checked to make sure it has an accessible description if needed                      no-restricted-syntax
  206:6  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/alignment-matrix-control/cell.tsx
  22:3  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  22:3  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/border-box-control/border-box-control-linked-button/component.tsx
  28:3  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  28:3  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  30:5  error  Button needs to be checked to make sure it has an accessible description if needed                no-restricted-syntax

/packages/components/src/border-control/border-control-dropdown/component.tsx
  172:3  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/box-control/axial-input-controls.tsx
  106:7  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  106:7  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/box-control/input-controls.tsx
  108:7  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  108:7  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/box-control/linked-button.tsx
  20:3  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  20:3  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  21:4  error  Button needs to be checked to make sure it has an accessible description if needed                no-restricted-syntax

/packages/components/src/button/index.native.js
  225:3  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  225:3  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/button/index.tsx
  280:4  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  280:4  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/button/stories/index.story.tsx
  110:4  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  111:4  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  112:4  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/button/test/index.tsx
  104:5   error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  104:5   error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  116:6   error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  116:6   error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  117:7   error  Button needs to be checked to make sure it has an accessible description if needed                no-restricted-syntax
  153:6   error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  153:6   error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  154:7   error  Button needs to be checked to make sure it has an accessible description if needed                no-restricted-syntax
  196:5   error  Button needs to be checked to make sure it has an accessible description if needed                no-restricted-syntax
  222:14  error  Button needs to be checked to make sure it has an accessible description if needed                no-restricted-syntax
  302:12  error  Button needs to be checked to make sure it has an accessible description if needed                no-restricted-syntax
  313:12  error  Button needs to be checked to make sure it has an accessible description if needed                no-restricted-syntax
  322:12  error  Button needs to be checked to make sure it has an accessible description if needed                no-restricted-syntax
  332:5   error  Button needs to be checked to make sure it has an accessible description if needed                no-restricted-syntax
  332:5   error  Button needs to be checked to make sure it has an accessible description if needed                no-restricted-syntax
  351:5   error  Button needs to be checked to make sure it has an accessible description if needed                no-restricted-syntax
  401:5   error  Button needs to be checked to make sure it has an accessible description if needed                no-restricted-syntax
  416:5   error  Button needs to be checked to make sure it has an accessible description if needed                no-restricted-syntax

/packages/components/src/circular-option-picker/circular-option-picker-option.tsx
  115:5  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  115:5  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/color-picker/color-copy-button.tsx
  59:3  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  59:3  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/combobox-control/index.tsx
  359:9  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/composite/stories/index.story.tsx
  385:5  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  385:5  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  388:5  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  388:5  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  391:5  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  391:5  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/custom-gradient-picker/gradient-bar/control-points.tsx
  57:4  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  57:4  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/date-time/date/index.tsx
  114:5  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  140:5  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/date-time/time/timezone.tsx
  53:3  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  53:3  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/dropdown-menu/index.native.js
  86:6  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/dropdown-menu/index.tsx
  166:9  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/dropdown-menu/test/index.tsx
  20:11  error  DropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  27:11  error  DropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  59:11  error  DropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  80:4   error  DropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/focal-point-picker/index.native.js
  207:4  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  207:4  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/form-token-field/token.tsx
  73:4  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  73:4  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/guide/page-control.tsx
  29:6  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/input-control/stories/index.story.tsx
   96:4  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  122:6  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/modal/index.tsx
  340:11  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/modal/stories/index.story.tsx
  113:3  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/navigation/menu/menu-title.tsx
  68:9  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/notice/index.tsx
  162:5  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/palette-edit/index.tsx
  218:5  error  Button needs to be checked to make sure it has an accessible description if needed                     no-restricted-syntax
  443:7  error  Button needs to be checked to make sure it has an accessible description if needed                     no-restricted-syntax
  489:8  error  DropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/range-control/tooltip.tsx
  41:3  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  41:3  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/resizable-box/resize-tooltip/label.tsx
  87:4  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  87:4  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/search-control/index.native.js
  187:5  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  214:5  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/search-control/index.tsx
  47:3  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/tabs/stories/index.story.tsx
  238:6  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed       no-restricted-syntax
  238:6  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed       no-restricted-syntax
  397:5  error  DropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/toggle-group-control/toggle-group-control-option-base/component.tsx
  32:4  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  32:4  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/toolbar/stories/index.story.tsx
   89:5  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed        no-restricted-syntax
   94:7  error  DropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed         no-restricted-syntax
  118:5  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed        no-restricted-syntax
  119:5  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed        no-restricted-syntax
  120:5  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed        no-restricted-syntax
  121:5  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed        no-restricted-syntax
  150:4  error  ToolbarDropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  182:4  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed        no-restricted-syntax
  183:4  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed        no-restricted-syntax
  184:4  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed        no-restricted-syntax

/packages/components/src/toolbar/test/index.tsx
  16:6  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  17:6  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/toolbar/toolbar-button/index.tsx
  54:5  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  54:5  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  99:5  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/toolbar/toolbar-dropdown-menu/index.tsx
  26:10  error  DropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  35:5   error  DropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/toolbar/toolbar-group/index.tsx
  103:6  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/toolbar/toolbar-group/toolbar-group-collapsed.native.js
  31:4  error  DropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/toolbar/toolbar-group/toolbar-group-collapsed.tsx
  27:3  error  DropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/tools-panel/tools-panel-header/component.tsx
  196:5  error  DropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/tooltip/stories/index.story.tsx
  43:2  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  43:2  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  71:3  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  71:3  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/tooltip/test/index.native.js
  43:4  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  43:4  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  55:4  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  55:4  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  71:4  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  71:4  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/components/src/tooltip/test/index.tsx
   49:5   error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
   49:5   error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
   69:5   error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
   69:5   error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
   79:12  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
   79:12  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
   99:12  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
   99:12  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  111:6   error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  111:6   error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  134:6   error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  134:6   error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  166:12  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  166:12  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  186:6   error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  186:6   error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  212:12  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  212:12  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  232:6   error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  232:6   error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  262:5   error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  262:5   error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  303:5   error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  303:5   error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  345:12  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  345:12  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  366:5   error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  366:5   error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  434:5   error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  434:5   error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  435:6   error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  435:6   error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  436:7   error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  436:7   error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  476:5   error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  476:5   error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  477:6   error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  477:6   error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/customize-widgets/src/components/header/index.js
  55:6  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  64:6  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  74:6  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/customize-widgets/src/components/inserter/index.js
  39:5  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/customize-widgets/src/components/more-menu/index.js
  37:4  error  ToolbarDropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/dataviews/src/components/dataviews-bulk-actions/index.tsx
  129:3  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/dataviews/src/components/dataviews-filters/filter-summary.tsx
  257:6  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  257:6  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  294:7  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  294:7  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/dataviews/src/components/dataviews-filters/index.tsx
  109:6  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  123:4  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/dataviews/src/components/dataviews-item-actions/index.tsx
   70:3  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  250:5  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/dataviews/src/components/dataviews-view-config/index.tsx
   74:5  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  279:8  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  306:8  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  335:6  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  538:6  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/dataviews/src/dataforms-layouts/panel/index.tsx
   47:6  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  101:7  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/dataviews/src/dataviews-layouts/list/index.tsx
   94:6   error  Button needs to be checked to make sure it has an accessible description if needed                     no-restricted-syntax
  117:6   error  Button needs to be checked to make sure it has an accessible description if needed                     no-restricted-syntax
  279:8   error  DropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  286:12  error  Button needs to be checked to make sure it has an accessible description if needed                     no-restricted-syntax

/packages/edit-post/src/components/layout/index.js
  309:7  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  309:7  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/edit-site/src/components/add-new-pattern/index.js
  130:5  error  DropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/edit-site/src/components/add-new-template/index.js
  354:4  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/edit-site/src/components/editor-canvas-container/index.js
  127:8  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/edit-site/src/components/global-styles-sidebar/index.js
  139:7  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  152:7  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/edit-site/src/components/global-styles/font-library-modal/font-collection.js
  259:4  error  DropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  545:8  error  Button needs to be checked to make sure it has an accessible description if needed                     no-restricted-syntax

/packages/edit-site/src/components/global-styles/font-sizes/font-size.js
  171:11  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/edit-site/src/components/global-styles/font-sizes/font-sizes.js
  76:8   error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  86:10  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/edit-site/src/components/global-styles/screen-revisions/revisions-buttons.js
  164:7  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/edit-site/src/components/global-styles/shadows-edit-panel.js
  168:9  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  329:7  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/edit-site/src/components/global-styles/shadows-panel.js
  108:7  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/edit-site/src/components/global-styles/ui.js
  79:4  error  DropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/edit-site/src/components/global-styles/variations/variation.js
  102:5  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  102:5  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/edit-site/src/components/page-patterns/fields.js
  148:5  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  148:5  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/edit-site/src/components/page-patterns/header.js
  78:7  error  DropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/edit-site/src/components/pagination/index.js
  47:5  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  56:5  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  75:5  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  84:5  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/edit-site/src/components/post-list/index.js
  411:7  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/edit-site/src/components/resizable-frame/index.js
  280:7  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  280:7  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/edit-site/src/components/save-button/index.js
  130:3  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/edit-site/src/components/sidebar-dataviews/custom-dataviews-list.js
  116:6  error  DropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/edit-site/src/components/sidebar-navigation-screen-navigation-menu/more-menu.js
  41:4  error  DropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/edit-site/src/components/sidebar-navigation-screen-navigation-menus/leaf-more-menu.js
  92:3  error  DropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/edit-site/src/components/site-hub/index.js
   64:7  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  101:8  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  101:8  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  148:7  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  168:8  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  183:8  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  183:8  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/edit-widgets/src/components/header/undo-redo/redo.js
  23:3  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  23:3  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/edit-widgets/src/components/header/undo-redo/undo.js
  19:3  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  19:3  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/edit-widgets/src/components/more-menu/index.js
  41:4  error  DropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/edit-widgets/src/components/secondary-sidebar/inserter-sidebar.js
  46:5  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/edit-widgets/src/components/secondary-sidebar/list-view-sidebar.js
  53:5  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/editor/src/components/blog-title/index.js
  93:6  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/editor/src/components/collapsible-block-toolbar/index.js
  60:4  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/editor/src/components/editor-history/redo.js
  27:3  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  27:3  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/editor/src/components/editor-history/undo.js
  23:3  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  23:3  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/editor/src/components/more-menu/index.js
  44:4  error  DropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/editor/src/components/page-attributes/parent.js
  210:3  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/editor/src/components/post-actions/index.js
  60:5  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/editor/src/components/post-author/panel.js
  23:3  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/editor/src/components/post-discussion/panel.js
  77:3  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/editor/src/components/post-featured-image/index.js
  162:9  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  162:9  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/editor/src/components/post-format/panel.js
  58:7  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/editor/src/components/post-publish-panel/index.js
  94:7  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/editor/src/components/post-saved-state/index.js
  151:3  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  151:3  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/editor/src/components/post-schedule/panel.js
  71:7  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/editor/src/components/post-status/index.js
  175:7  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/editor/src/components/post-template/block-theme.js
  93:3  error  DropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/editor/src/components/post-template/classic-theme.js
  48:3  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/editor/src/components/post-url/index.js
  114:10  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/editor/src/components/post-url/panel.js
  84:3  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/editor/src/components/posts-per-page/index.js
  71:6  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/editor/src/components/preview-dropdown/index.js
  108:3  error  DropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/editor/src/components/resizable-editor/resize-handle.js
  47:4  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax
  47:4  error  Tooltip needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/editor/src/components/site-discussion/index.js
  93:6  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/editor/src/components/table-of-contents/index.js
  32:5  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/editor/src/components/text-editor/index.js
  42:6  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/interface/src/components/complementary-area/index.js
  318:9  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/nux/src/components/dot-tip/index.js
  67:4  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/patterns/src/components/pattern-overrides-block-controls.js
  83:5  error  DropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/patterns/src/components/reset-overrides-control.js
  84:5  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/widgets/src/blocks/legacy-widget/edit/convert-to-blocks-button.js
  14:3  error  ToolbarButton needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/packages/widgets/src/components/move-to-widget-area/index.js
  23:6  error  DropdownMenu needs to have its anchor checked to make sure it has an accessible description if needed  no-restricted-syntax

/storybook/stories/playground/with-undo-redo/index.js
  49:6  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax
  56:6  error  Button needs to be checked to make sure it has an accessible description if needed  no-restricted-syntax

✖ 410 problems (410 errors, 0 warnings)


Could y'all help to review and expand the ESLint rules? The tricky part is to catch and derivative usage of Tooltips, like for toolbar items, dropdowns, etc.

Could be a good opportunity to involve a broader group of contributors, just like we did for #65018.

@tyxla The collaboration on #65018 was great, although on many occasions reviewing the PR took me a long time (equivalent to authoring the PR myself) given the lack of testing instructions and / or some changes being applied superficially (ie. without considering style overrides, etc). Do you have ideas on how to improve on this aspect?

Copy link

Size Change: -65 B (0%)

Total Size: 1.77 MB

Filename Size Change
build/components/index.min.js 227 kB -65 B (-0.03%)
ℹ️ View Unchanged
Filename Size
build-module/a11y/index.min.js 482 B
build-module/block-library/file/view.min.js 447 B
build-module/block-library/image/view.min.js 1.78 kB
build-module/block-library/navigation/view.min.js 1.16 kB
build-module/block-library/query/view.min.js 742 B
build-module/block-library/search/view.min.js 616 B
build-module/interactivity-router/index.min.js 3.03 kB
build-module/interactivity/debug.min.js 17.2 kB
build-module/interactivity/index.min.js 13.6 kB
build/a11y/index.min.js 952 B
build/annotations/index.min.js 2.26 kB
build/api-fetch/index.min.js 2.32 kB
build/autop/index.min.js 2.12 kB
build/blob/index.min.js 579 B
build/block-directory/index.min.js 7.26 kB
build/block-directory/style-rtl.css 1.07 kB
build/block-directory/style.css 1.07 kB
build/block-editor/content-rtl.css 4.38 kB
build/block-editor/content.css 4.38 kB
build/block-editor/default-editor-styles-rtl.css 394 B
build/block-editor/default-editor-styles.css 394 B
build/block-editor/index.min.js 256 kB
build/block-editor/style-rtl.css 15.4 kB
build/block-editor/style.css 15.4 kB
build/block-library/blocks/archives/editor-rtl.css 61 B
build/block-library/blocks/archives/editor.css 60 B
build/block-library/blocks/archives/style-rtl.css 90 B
build/block-library/blocks/archives/style.css 90 B
build/block-library/blocks/audio/editor-rtl.css 149 B
build/block-library/blocks/audio/editor.css 151 B
build/block-library/blocks/audio/style-rtl.css 132 B
build/block-library/blocks/audio/style.css 132 B
build/block-library/blocks/audio/theme-rtl.css 134 B
build/block-library/blocks/audio/theme.css 134 B
build/block-library/blocks/avatar/editor-rtl.css 115 B
build/block-library/blocks/avatar/editor.css 115 B
build/block-library/blocks/avatar/style-rtl.css 104 B
build/block-library/blocks/avatar/style.css 104 B
build/block-library/blocks/button/editor-rtl.css 265 B
build/block-library/blocks/button/editor.css 265 B
build/block-library/blocks/button/style-rtl.css 538 B
build/block-library/blocks/button/style.css 538 B
build/block-library/blocks/buttons/editor-rtl.css 291 B
build/block-library/blocks/buttons/editor.css 291 B
build/block-library/blocks/buttons/style-rtl.css 345 B
build/block-library/blocks/buttons/style.css 345 B
build/block-library/blocks/calendar/style-rtl.css 240 B
build/block-library/blocks/calendar/style.css 240 B
build/block-library/blocks/categories/editor-rtl.css 132 B
build/block-library/blocks/categories/editor.css 131 B
build/block-library/blocks/categories/style-rtl.css 152 B
build/block-library/blocks/categories/style.css 152 B
build/block-library/blocks/code/editor-rtl.css 53 B
build/block-library/blocks/code/editor.css 53 B
build/block-library/blocks/code/style-rtl.css 121 B
build/block-library/blocks/code/style.css 121 B
build/block-library/blocks/code/theme-rtl.css 122 B
build/block-library/blocks/code/theme.css 122 B
build/block-library/blocks/columns/editor-rtl.css 108 B
build/block-library/blocks/columns/editor.css 108 B
build/block-library/blocks/columns/style-rtl.css 420 B
build/block-library/blocks/columns/style.css 420 B
build/block-library/blocks/comment-author-avatar/editor-rtl.css 124 B
build/block-library/blocks/comment-author-avatar/editor.css 124 B
build/block-library/blocks/comment-author-name/style-rtl.css 72 B
build/block-library/blocks/comment-author-name/style.css 72 B
build/block-library/blocks/comment-content/style-rtl.css 120 B
build/block-library/blocks/comment-content/style.css 120 B
build/block-library/blocks/comment-date/style-rtl.css 65 B
build/block-library/blocks/comment-date/style.css 65 B
build/block-library/blocks/comment-edit-link/style-rtl.css 70 B
build/block-library/blocks/comment-edit-link/style.css 70 B
build/block-library/blocks/comment-reply-link/style-rtl.css 71 B
build/block-library/blocks/comment-reply-link/style.css 71 B
build/block-library/blocks/comment-template/style-rtl.css 200 B
build/block-library/blocks/comment-template/style.css 199 B
build/block-library/blocks/comments-pagination-numbers/editor-rtl.css 122 B
build/block-library/blocks/comments-pagination-numbers/editor.css 121 B
build/block-library/blocks/comments-pagination/editor-rtl.css 228 B
build/block-library/blocks/comments-pagination/editor.css 217 B
build/block-library/blocks/comments-pagination/style-rtl.css 234 B
build/block-library/blocks/comments-pagination/style.css 231 B
build/block-library/blocks/comments-title/editor-rtl.css 75 B
build/block-library/blocks/comments-title/editor.css 75 B
build/block-library/blocks/comments/editor-rtl.css 832 B
build/block-library/blocks/comments/editor.css 832 B
build/block-library/blocks/comments/style-rtl.css 632 B
build/block-library/blocks/comments/style.css 631 B
build/block-library/blocks/cover/editor-rtl.css 640 B
build/block-library/blocks/cover/editor.css 641 B
build/block-library/blocks/cover/style-rtl.css 1.62 kB
build/block-library/blocks/cover/style.css 1.61 kB
build/block-library/blocks/details/editor-rtl.css 65 B
build/block-library/blocks/details/editor.css 65 B
build/block-library/blocks/details/style-rtl.css 86 B
build/block-library/blocks/details/style.css 86 B
build/block-library/blocks/embed/editor-rtl.css 331 B
build/block-library/blocks/embed/editor.css 331 B
build/block-library/blocks/embed/style-rtl.css 419 B
build/block-library/blocks/embed/style.css 419 B
build/block-library/blocks/embed/theme-rtl.css 133 B
build/block-library/blocks/embed/theme.css 133 B
build/block-library/blocks/file/editor-rtl.css 326 B
build/block-library/blocks/file/editor.css 326 B
build/block-library/blocks/file/style-rtl.css 278 B
build/block-library/blocks/file/style.css 279 B
build/block-library/blocks/footnotes/style-rtl.css 198 B
build/block-library/blocks/footnotes/style.css 197 B
build/block-library/blocks/form-input/editor-rtl.css 229 B
build/block-library/blocks/form-input/editor.css 229 B
build/block-library/blocks/form-input/style-rtl.css 357 B
build/block-library/blocks/form-input/style.css 357 B
build/block-library/blocks/form-submission-notification/editor-rtl.css 344 B
build/block-library/blocks/form-submission-notification/editor.css 341 B
build/block-library/blocks/form-submit-button/style-rtl.css 69 B
build/block-library/blocks/form-submit-button/style.css 69 B
build/block-library/blocks/form/view.min.js 470 B
build/block-library/blocks/freeform/editor-rtl.css 2.6 kB
build/block-library/blocks/freeform/editor.css 2.6 kB
build/block-library/blocks/gallery/editor-rtl.css 946 B
build/block-library/blocks/gallery/editor.css 951 B
build/block-library/blocks/gallery/style-rtl.css 1.83 kB
build/block-library/blocks/gallery/style.css 1.82 kB
build/block-library/blocks/gallery/theme-rtl.css 108 B
build/block-library/blocks/gallery/theme.css 108 B
build/block-library/blocks/group/editor-rtl.css 334 B
build/block-library/blocks/group/editor.css 334 B
build/block-library/blocks/group/style-rtl.css 103 B
build/block-library/blocks/group/style.css 103 B
build/block-library/blocks/group/theme-rtl.css 79 B
build/block-library/blocks/group/theme.css 79 B
build/block-library/blocks/heading/style-rtl.css 188 B
build/block-library/blocks/heading/style.css 188 B
build/block-library/blocks/html/editor-rtl.css 346 B
build/block-library/blocks/html/editor.css 347 B
build/block-library/blocks/image/editor-rtl.css 785 B
build/block-library/blocks/image/editor.css 787 B
build/block-library/blocks/image/style-rtl.css 1.59 kB
build/block-library/blocks/image/style.css 1.59 kB
build/block-library/blocks/image/theme-rtl.css 137 B
build/block-library/blocks/image/theme.css 137 B
build/block-library/blocks/latest-comments/style-rtl.css 355 B
build/block-library/blocks/latest-comments/style.css 354 B
build/block-library/blocks/latest-posts/editor-rtl.css 179 B
build/block-library/blocks/latest-posts/editor.css 179 B
build/block-library/blocks/latest-posts/style-rtl.css 509 B
build/block-library/blocks/latest-posts/style.css 510 B
build/block-library/blocks/list/style-rtl.css 107 B
build/block-library/blocks/list/style.css 107 B
build/block-library/blocks/loginout/style-rtl.css 61 B
build/block-library/blocks/loginout/style.css 61 B
build/block-library/blocks/media-text/editor-rtl.css 321 B
build/block-library/blocks/media-text/editor.css 320 B
build/block-library/blocks/media-text/style-rtl.css 558 B
build/block-library/blocks/media-text/style.css 556 B
build/block-library/blocks/more/editor-rtl.css 427 B
build/block-library/blocks/more/editor.css 427 B
build/block-library/blocks/navigation-link/editor-rtl.css 644 B
build/block-library/blocks/navigation-link/editor.css 645 B
build/block-library/blocks/navigation-link/style-rtl.css 192 B
build/block-library/blocks/navigation-link/style.css 191 B
build/block-library/blocks/navigation-submenu/editor-rtl.css 295 B
build/block-library/blocks/navigation-submenu/editor.css 294 B
build/block-library/blocks/navigation/editor-rtl.css 2.19 kB
build/block-library/blocks/navigation/editor.css 2.2 kB
build/block-library/blocks/navigation/style-rtl.css 2.25 kB
build/block-library/blocks/navigation/style.css 2.23 kB
build/block-library/blocks/nextpage/editor-rtl.css 392 B
build/block-library/blocks/nextpage/editor.css 392 B
build/block-library/blocks/page-list/editor-rtl.css 378 B
build/block-library/blocks/page-list/editor.css 378 B
build/block-library/blocks/page-list/style-rtl.css 175 B
build/block-library/blocks/page-list/style.css 175 B
build/block-library/blocks/paragraph/editor-rtl.css 236 B
build/block-library/blocks/paragraph/editor.css 236 B
build/block-library/blocks/paragraph/style-rtl.css 341 B
build/block-library/blocks/paragraph/style.css 340 B
build/block-library/blocks/post-author-biography/style-rtl.css 74 B
build/block-library/blocks/post-author-biography/style.css 74 B
build/block-library/blocks/post-author-name/style-rtl.css 69 B
build/block-library/blocks/post-author-name/style.css 69 B
build/block-library/blocks/post-author/editor-rtl.css 107 B
build/block-library/blocks/post-author/editor.css 107 B
build/block-library/blocks/post-author/style-rtl.css 188 B
build/block-library/blocks/post-author/style.css 189 B
build/block-library/blocks/post-comments-form/editor-rtl.css 96 B
build/block-library/blocks/post-comments-form/editor.css 96 B
build/block-library/blocks/post-comments-form/style-rtl.css 527 B
build/block-library/blocks/post-comments-form/style.css 528 B
build/block-library/blocks/post-content/style-rtl.css 61 B
build/block-library/blocks/post-content/style.css 61 B
build/block-library/blocks/post-date/style-rtl.css 62 B
build/block-library/blocks/post-date/style.css 62 B
build/block-library/blocks/post-excerpt/editor-rtl.css 71 B
build/block-library/blocks/post-excerpt/editor.css 71 B
build/block-library/blocks/post-excerpt/style-rtl.css 155 B
build/block-library/blocks/post-excerpt/style.css 155 B
build/block-library/blocks/post-featured-image/editor-rtl.css 729 B
build/block-library/blocks/post-featured-image/editor.css 726 B
build/block-library/blocks/post-featured-image/style-rtl.css 347 B
build/block-library/blocks/post-featured-image/style.css 347 B
build/block-library/blocks/post-navigation-link/style-rtl.css 215 B
build/block-library/blocks/post-navigation-link/style.css 214 B
build/block-library/blocks/post-template/editor-rtl.css 99 B
build/block-library/blocks/post-template/editor.css 98 B
build/block-library/blocks/post-template/style-rtl.css 399 B
build/block-library/blocks/post-template/style.css 398 B
build/block-library/blocks/post-terms/style-rtl.css 96 B
build/block-library/blocks/post-terms/style.css 96 B
build/block-library/blocks/post-time-to-read/style-rtl.css 70 B
build/block-library/blocks/post-time-to-read/style.css 70 B
build/block-library/blocks/post-title/style-rtl.css 162 B
build/block-library/blocks/post-title/style.css 162 B
build/block-library/blocks/preformatted/style-rtl.css 125 B
build/block-library/blocks/preformatted/style.css 125 B
build/block-library/blocks/pullquote/editor-rtl.css 134 B
build/block-library/blocks/pullquote/editor.css 134 B
build/block-library/blocks/pullquote/style-rtl.css 342 B
build/block-library/blocks/pullquote/style.css 342 B
build/block-library/blocks/pullquote/theme-rtl.css 167 B
build/block-library/blocks/pullquote/theme.css 167 B
build/block-library/blocks/query-pagination-numbers/editor-rtl.css 121 B
build/block-library/blocks/query-pagination-numbers/editor.css 118 B
build/block-library/blocks/query-pagination/editor-rtl.css 154 B
build/block-library/blocks/query-pagination/editor.css 154 B
build/block-library/blocks/query-pagination/style-rtl.css 237 B
build/block-library/blocks/query-pagination/style.css 237 B
build/block-library/blocks/query-title/style-rtl.css 64 B
build/block-library/blocks/query-title/style.css 64 B
build/block-library/blocks/query/editor-rtl.css 452 B
build/block-library/blocks/query/editor.css 451 B
build/block-library/blocks/quote/style-rtl.css 238 B
build/block-library/blocks/quote/style.css 238 B
build/block-library/blocks/quote/theme-rtl.css 233 B
build/block-library/blocks/quote/theme.css 236 B
build/block-library/blocks/read-more/style-rtl.css 138 B
build/block-library/blocks/read-more/style.css 138 B
build/block-library/blocks/rss/editor-rtl.css 101 B
build/block-library/blocks/rss/editor.css 101 B
build/block-library/blocks/rss/style-rtl.css 288 B
build/block-library/blocks/rss/style.css 287 B
build/block-library/blocks/search/editor-rtl.css 199 B
build/block-library/blocks/search/editor.css 199 B
build/block-library/blocks/search/style-rtl.css 672 B
build/block-library/blocks/search/style.css 671 B
build/block-library/blocks/search/theme-rtl.css 113 B
build/block-library/blocks/search/theme.css 113 B
build/block-library/blocks/separator/editor-rtl.css 100 B
build/block-library/blocks/separator/editor.css 100 B
build/block-library/blocks/separator/style-rtl.css 248 B
build/block-library/blocks/separator/style.css 248 B
build/block-library/blocks/separator/theme-rtl.css 195 B
build/block-library/blocks/separator/theme.css 195 B
build/block-library/blocks/shortcode/editor-rtl.css 286 B
build/block-library/blocks/shortcode/editor.css 286 B
build/block-library/blocks/site-logo/editor-rtl.css 806 B
build/block-library/blocks/site-logo/editor.css 803 B
build/block-library/blocks/site-logo/style-rtl.css 218 B
build/block-library/blocks/site-logo/style.css 218 B
build/block-library/blocks/site-tagline/editor-rtl.css 87 B
build/block-library/blocks/site-tagline/editor.css 87 B
build/block-library/blocks/site-tagline/style-rtl.css 65 B
build/block-library/blocks/site-tagline/style.css 65 B
build/block-library/blocks/site-title/editor-rtl.css 85 B
build/block-library/blocks/site-title/editor.css 85 B
build/block-library/blocks/site-title/style-rtl.css 143 B
build/block-library/blocks/site-title/style.css 143 B
build/block-library/blocks/social-link/editor-rtl.css 338 B
build/block-library/blocks/social-link/editor.css 338 B
build/block-library/blocks/social-links/editor-rtl.css 729 B
build/block-library/blocks/social-links/editor.css 727 B
build/block-library/blocks/social-links/style-rtl.css 1.51 kB
build/block-library/blocks/social-links/style.css 1.5 kB
build/block-library/blocks/spacer/editor-rtl.css 346 B
build/block-library/blocks/spacer/editor.css 346 B
build/block-library/blocks/spacer/style-rtl.css 48 B
build/block-library/blocks/spacer/style.css 48 B
build/block-library/blocks/table-of-contents/style-rtl.css 83 B
build/block-library/blocks/table-of-contents/style.css 83 B
build/block-library/blocks/table/editor-rtl.css 394 B
build/block-library/blocks/table/editor.css 394 B
build/block-library/blocks/table/style-rtl.css 640 B
build/block-library/blocks/table/style.css 639 B
build/block-library/blocks/table/theme-rtl.css 152 B
build/block-library/blocks/table/theme.css 152 B
build/block-library/blocks/tag-cloud/editor-rtl.css 144 B
build/block-library/blocks/tag-cloud/editor.css 144 B
build/block-library/blocks/tag-cloud/style-rtl.css 266 B
build/block-library/blocks/tag-cloud/style.css 265 B
build/block-library/blocks/template-part/editor-rtl.css 368 B
build/block-library/blocks/template-part/editor.css 368 B
build/block-library/blocks/template-part/theme-rtl.css 113 B
build/block-library/blocks/template-part/theme.css 113 B
build/block-library/blocks/term-description/style-rtl.css 126 B
build/block-library/blocks/term-description/style.css 126 B
build/block-library/blocks/text-columns/editor-rtl.css 95 B
build/block-library/blocks/text-columns/editor.css 95 B
build/block-library/blocks/text-columns/style-rtl.css 165 B
build/block-library/blocks/text-columns/style.css 165 B
build/block-library/blocks/verse/style-rtl.css 98 B
build/block-library/blocks/verse/style.css 98 B
build/block-library/blocks/video/editor-rtl.css 396 B
build/block-library/blocks/video/editor.css 397 B
build/block-library/blocks/video/style-rtl.css 192 B
build/block-library/blocks/video/style.css 192 B
build/block-library/blocks/video/theme-rtl.css 134 B
build/block-library/blocks/video/theme.css 134 B
build/block-library/classic-rtl.css 179 B
build/block-library/classic.css 179 B
build/block-library/common-rtl.css 1.1 kB
build/block-library/common.css 1.1 kB
build/block-library/editor-elements-rtl.css 75 B
build/block-library/editor-elements.css 75 B
build/block-library/editor-rtl.css 11.7 kB
build/block-library/editor.css 11.7 kB
build/block-library/elements-rtl.css 54 B
build/block-library/elements.css 54 B
build/block-library/index.min.js 219 kB
build/block-library/reset-rtl.css 472 B
build/block-library/reset.css 472 B
build/block-library/style-rtl.css 14.9 kB
build/block-library/style.css 14.9 kB
build/block-library/theme-rtl.css 708 B
build/block-library/theme.css 712 B
build/block-serialization-default-parser/index.min.js 1.12 kB
build/block-serialization-spec-parser/index.min.js 2.87 kB
build/blocks/index.min.js 52.5 kB
build/commands/index.min.js 16.1 kB
build/commands/style-rtl.css 955 B
build/commands/style.css 952 B
build/components/style-rtl.css 12.4 kB
build/components/style.css 12.4 kB
build/compose/index.min.js 12.7 kB
build/core-commands/index.min.js 3.11 kB
build/core-data/index.min.js 73.4 kB
build/customize-widgets/index.min.js 11 kB
build/customize-widgets/style-rtl.css 1.35 kB
build/customize-widgets/style.css 1.35 kB
build/data-controls/index.min.js 641 B
build/data/index.min.js 8.97 kB
build/date/index.min.js 18 kB
build/deprecated/index.min.js 458 B
build/dom-ready/index.min.js 325 B
build/dom/index.min.js 4.66 kB
build/edit-post/classic-rtl.css 578 B
build/edit-post/classic.css 580 B
build/edit-post/index.min.js 13.7 kB
build/edit-post/style-rtl.css 2.76 kB
build/edit-post/style.css 2.75 kB
build/edit-site/index.min.js 217 kB
build/edit-site/posts-rtl.css 7.34 kB
build/edit-site/posts.css 7.35 kB
build/edit-site/style-rtl.css 12.6 kB
build/edit-site/style.css 12.6 kB
build/edit-widgets/index.min.js 17.8 kB
build/edit-widgets/style-rtl.css 4.19 kB
build/edit-widgets/style.css 4.19 kB
build/editor/index.min.js 103 kB
build/editor/style-rtl.css 9.33 kB
build/editor/style.css 9.33 kB
build/element/index.min.js 4.82 kB
build/escape-html/index.min.js 537 B
build/format-library/index.min.js 8.04 kB
build/format-library/style-rtl.css 476 B
build/format-library/style.css 476 B
build/hooks/index.min.js 1.65 kB
build/html-entities/index.min.js 445 B
build/i18n/index.min.js 3.58 kB
build/is-shallow-equal/index.min.js 526 B
build/keyboard-shortcuts/index.min.js 1.31 kB
build/keycodes/index.min.js 1.46 kB
build/list-reusable-blocks/index.min.js 2.13 kB
build/list-reusable-blocks/style-rtl.css 852 B
build/list-reusable-blocks/style.css 852 B
build/media-utils/index.min.js 3.2 kB
build/notices/index.min.js 946 B
build/nux/index.min.js 1.62 kB
build/nux/style-rtl.css 749 B
build/nux/style.css 745 B
build/patterns/index.min.js 7.34 kB
build/patterns/style-rtl.css 687 B
build/patterns/style.css 685 B
build/plugins/index.min.js 1.81 kB
build/preferences-persistence/index.min.js 2.06 kB
build/preferences/index.min.js 2.9 kB
build/preferences/style-rtl.css 554 B
build/preferences/style.css 554 B
build/primitives/index.min.js 829 B
build/priority-queue/index.min.js 1.54 kB
build/private-apis/index.min.js 960 B
build/react-i18n/index.min.js 630 B
build/react-refresh-entry/index.min.js 9.47 kB
build/react-refresh-runtime/index.min.js 6.76 kB
build/redux-routine/index.min.js 2.7 kB
build/reusable-blocks/index.min.js 2.55 kB
build/reusable-blocks/style-rtl.css 256 B
build/reusable-blocks/style.css 256 B
build/rich-text/index.min.js 10.1 kB
build/router/index.min.js 1.96 kB
build/server-side-render/index.min.js 1.94 kB
build/shortcode/index.min.js 1.4 kB
build/style-engine/index.min.js 2.04 kB
build/token-list/index.min.js 581 B
build/url/index.min.js 3.9 kB
build/vendors/react-dom.min.js 41.7 kB
build/vendors/react-jsx-runtime.min.js 556 B
build/vendors/react.min.js 4.02 kB
build/viewport/index.min.js 965 B
build/warning/index.min.js 250 B
build/widgets/index.min.js 7.16 kB
build/widgets/style-rtl.css 1.16 kB
build/widgets/style.css 1.16 kB
build/wordcount/index.min.js 1.03 kB

compressed-size-action

@tyxla
Copy link
Member

tyxla commented Oct 11, 2024

I started adding some initial temporary ESLint rules for the most obvious usages — here is a list of the matches:

Here is a list of the matches
Could y'all help to review and expand the ESLint rules? The tricky part is to catch and derivative usage of Tooltips, like for toolbar items, dropdowns, etc.

@mirka to the rescue, she's been writing a bunch of custom ESLint rules recently. Happy to help with reviewing myself.

Could be a good opportunity to involve a broader group of contributors, just like we did for #65018.

@tyxla The collaboration on #65018 was great, although on many occasions reviewing the PR took me a long time (equivalent to authoring the PR myself) given the lack of testing instructions and / or some changes being applied superficially (ie. without considering style overrides, etc). Do you have ideas on how to improve on this aspect?

Yeah, that's a good question to ask ourselves.

I think we can be better at setting the right expectations for everyone, detailing step-by-step the process that we expect every change to include, including where to start, what to check, and what the end result looks like. In the Button size migration, we didn't really do that. We linked to an example, but we didn't explicitly state all the tricky bits like style overrides. So this time, we might want to be explicit about all these details. We could learn what those are by making the first few migrations ourselves and documenting every step on our way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants