Navigation: Avoid using embedded record from fallback API #59076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
Mamaduka
requested review from
youknowriad,
scruffian and
getdave
and removed request for
nerrad
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -71 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
Mamaduka
added
the
Backport to WP 6.7 Beta/RC
|
Flaky tests detected in 23c5ff4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7916905101
|
aristath
added a commit
that referenced
this pull request
Feb 16, 2024
* trunk: (78 commits) Components: Use `Element.scrollIntoView()` instead of `dom-scroll-into-view` (#59085) DataViews: Correctly display featured image that don't have image sizes (#59111) Elements: Fix block instance element styles for links applying to buttons (#59114) Allow editing of image block alt and title attributes in content only mode (#58998) Add toggle for grid types and stabilise Grid block variation. (#59051) Global Styles: fix console error in block preview (#59112) Navigation: Avoid using embedded records from fallback API (#59076) Refactor responsive logic for grid column spans. (#59057) Editor: Unify Mode Switcher component between post and site editor (#59100) Move StopEditingAsBlocksOnOutsideSelect to Root (#58412) Fix logic error in #58951 (#59101) Block-editor: Auto-register block commands (#59079) Fix small typo in rich text reference guide (#59089) Components: Add lint rules for theme color CSS var usage (#59022) Enter editing mode via Enter or Spacebar (#58795) Updating Storybook to v7.6.15 (latest) (#59074) CustomSelectControl (v1 & v2): Fix errors in unit test setup (#59038) Add stylelint rule to prevent theme CSS vars outside of wp-components (#59020) ColorPicker: Style without accessing InputControl internals (#59069) Pattern block: batch replacing actions (#59075) ...
|
Thanks for the ping. We're reverting functionality here that relied on functionality [external to the Nav block] that worked in WP 6.4 and now doesn't work in WP 6.5. That surely means that WP 6.5 suffered a regression and should be patched there in Core? The seeding was to avoid unwanted network requests and additional loading time on the Nav block by auto-populating the store. I'm AFK next couple of days but will try and look into this in more detail. |
|
@getdave, this is a temporary solution; many Navigation block-related e2e tests failed due to incomplete embedded responses. I was finally able to track down the exact cause of the regression. I'll revert this change as soon as WordPress/wordpress-develop#6133 lands in the core. |
getdave
pushed a commit
that referenced
this pull request
Feb 20, 2024
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
|
I just cherry-picked this PR to the cherry-pick-beta-2 branch to get it included in the next release: 27a9a28 |
getdave
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
added a commit
that referenced
this pull request
Feb 20, 2024
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #58987.
PR removes logic for seeding navigation record cache using an embedded record from fallback API.
Why?
tl;dr; Currently, the API returns incomplete data due to regression.
See #59058 and #58987 for details.
This should also resolve flaky navigation tests.
Testing Instructions
refattribute -<!-- wp:navigation /-->.refattribute is set.Testing Instructions for Keyboard
Same.