Update placeholder text color for standard themes #53719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekblank
changed the title
|
Size Change: 0 B Total Size: 1.51 MB ℹ️ View Unchanged
|
|
Hey @derekblank 👋 thanks for working on this task!
It looks like this theme is a block-based theme and not a standard theme (it has a theme.json file). You could use the Seedlet theme, for example, which is a standard theme. What we'd need to change is the default SCSS styles for the placeholders in the RichText component ( Thanks! |
Ah, thanks for the info! I'll check there using this theme. |
…heme-placeholder-text
|
@geriux I tested these changes with the Seedlet theme, and also the Russell theme, which was the theme that Chris initially reported the darker placeholder color. With the changes from this branch applied, the placeholder text color appears to display correctly: Placeholder.movI described the strategy for this change a bit further in this comment, as the gray colors used in |
derekblank
added
Mobile App - i.e. Android or iOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes placeholder text colors for standard themes.
Why?
Currently for sites using a standard theme like Russell, there is no distinction between a text input's primary color and its placeholder color.
How?
Removes the usage of the
globalStyles.textcolor as also functioning as the placeholder text color.Testing Instructions
Screenshots or screencast