[Site Editor]: Update the add template menu #50595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Enhancement
ntsekouras
commented
May 12, 2023
| @@ -25,46 +25,8 @@ | |||
|
|
|||
| &__contents { | |||
| > .components-button { | |||
| padding: $grid-unit-30; | |||
There was a problem hiding this comment.
These styles were moved below to be reused by both Modals. Only a couple of properties need to be different from each Modal right now. Also I'll have to remove any obsolete css in the end and update probably to use a single Modal.
ntsekouras
commented
May 12, 2023
|
Size Change: -1.52 kB (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 8cfd4d2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4959846764
|
|
This work may end up being superseded by #50395, but I think it's still an enhancement worth merging. If we don't get to 50395, at least we'll have a destination in which to send people for template creation, which is something the current popover doesn't offer. Couple of issues to address: 
|
|
I pushed some adjustments to the modal dimensions: add-template.mp4I'm not in love with the middle step, the whitespace of overly pronounced, but I think this is an acceptable trade-off vs the current experience, where the modals are constantly jumping around due to their different dimensions. The process feels like a single flow now rather than three disparate steps. |
ntsekouras
force-pushed
the
update/add-template-menu
branch
from
50a5cb5
to
12e50cf
Compare
Thank you @jameskoster! I've been refactoring a bit to reuse the same modal and will need more polishing. I pushed the first batch of changes and also added your changes, because I had to force push due to lots of conflicts. In general do you think this is something worth spending a bit more time to merge? Because you mentioned this could be superseded by #50395. |
ntsekouras
force-pushed
the
update/add-template-menu
branch
from
b171bcb
to
2517beb
Compare
😍 That was my only remaining gripe, and I assumed it would involve more work. Thanks for tackling this! For me this is worth merging, if it's not too time-consuming to get into a merge-able state. It's not 100% clear to me how much of #50395 we'll get to for 6.3, there's still some design work to be done there. This change feels like a really nice quality-of-life improvement to the current flow. |
ntsekouras
force-pushed
the
update/add-template-menu
branch
from
253ccea
to
5a939f2
Compare
|
Pushed a couple of minor tweaks. I think this feels like an enhancement versus the flow on trunk and is ready for merge, but would appreciate another set of eyes from @WordPress/gutenberg-design. |
ciampo
reviewed
May 16, 2023
jasmussen
approved these changes
May 17, 2023
There was a problem hiding this comment.
Definitely a step forward, kudos for pushing through on this, all involved.
Trunk shown in this GIF with a template dropdown:
This PR with a gif showing the dropdown replaced by a large and spacious modal:
There's an open question on mobile, forgive me if I missed conversation. But that simply fails silently, it appears:
Or rather, it appears, it's just impossible to create or even manage templates on mobile. Is this intentional? It seems separate to this issue though.
Co-authored-by: Marco Ciampini <marco.ciampo@gmail.com>
Yes, I checked the mobile now and observed some issues there in general with the header as well. Let's check them separately. |
This was referenced Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves: #50134
This PR updates the add template menu in site editor.