-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update npm run native start
to include cleanup
#28025
Conversation
7cf6143
to
6c58e94
Compare
👋 I've spotted that the command |
Oh sorry, I didn't saw the |
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
I'd change the first command of this part because Ensure that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I tested the commands and works fine.
PD: I added a comment about the PR's description because it doesn't match the code changes.
Description
This changes the
start
script to also do the cleanup previously done by the now-deprectedstart:reset
script. This is done to make the default script safer and to keep these commands consistent with gutenberg-mobile.How has this been tested?
Ensure that
npm run native start:reset
andnpm run native start:quick
both start the metro bundler. Also check thatnpm run native start
outputs an error message directing the user to thenpm run native start:reset
command.Types of changes
Tweaking the build setup
Checklist: