Docs/update button component props #24013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elaborates more on ToolbarComponent information, mentioning its accessibility features. Co-authored-by: Daniel Richards <daniel.p.richards@gmail.com>
Proper documentation links on ToolbarButton page. Co-authored-by: Marcus Kazmierczak <marcus@mkaz.com>
Proper links usage on ToolbarButton documentation page. Co-authored-by: Marcus Kazmierczak <marcus@mkaz.com>
Proper links usage on ToolbarButton documentation page. Co-authored-by: Marcus Kazmierczak <marcus@mkaz.com>
Proper links usage on ToolbarButton documentation page. Co-authored-by: Marcus Kazmierczak <marcus@mkaz.com>
…ttonGroup documentation.
mateuswetah
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
youknowriad
reviewed
Jul 20, 2020
| - Toolbars | ||
| - Modals | ||
| - Forms | ||
| - Toolbars |
There was a problem hiding this comment.
Why all lists are not formatted differently?
There was a problem hiding this comment.
Hi @youknowriad. I am not sure why, but after installing the prettier extension as in here, every time I saved my file the one space that I inserted was converted to two spaces ¬¬'. Is there anything that I should change in my pretter settings?
There was a problem hiding this comment.
I think it's probably fine because we don't have strong linting checks for markdown. 👍
youknowriad
added
[Type] Developer Documentation
youknowriad
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added missing props to the Button component props list, such as
className,target,icon,showTooltipand others related. Also, shows the props list more alike how it is done in other components: a list instead of a table.Types of changes
Documentation improvements