Small performance tweaks #23825
Merged
Small performance tweaks #23825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -20 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
youknowriad
force-pushed
the
try/performance-tweaks
branch
from
5faee36
to
ab3fb38
Compare
youknowriad
added
the
Backport to WP 6.7 Beta/RC
|
Seems like we're gaining 3ms out of 30ms in terms of typing. That's a 10% improvement for this tiny PR. |
|
@youknowriad These are great tips! Would it be helpful to have some performance tips documented, either as part of the |
|
@chrisvanpatten Definitely, I'm not really certain what's the best place for it, could be this page https://developer.wordpress.org/block-editor/principles/architecture/performance/ but I'd love to see these documented and other tips people have. |
youknowriad
added a commit
that referenced
this pull request
Jul 13, 2020
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not certain how much these small tweaks will improve performance but this PR could serve at least to raise some awareness.
Using
useSelectis not without costs. Everytime you return a value from useSelect,getBlockIndexchange often for blocks after the current selection. (Everytime a new block is added or removed)