-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components: Add Tooltip component, display button aria-label tooltips #2293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
General Interface
Parts of the UI which don't fall neatly under other labels.
[Feature] UI Components
Impacts or related to the UI component system
labels
Aug 8, 2017
|
Structurally matches IconButton, but semantically the two serve different purposes
Since role of tooltip best serves icons with no supplementary text
Codecov Report
@@ Coverage Diff @@
## master #2293 +/- ##
==========================================
+ Coverage 24.95% 25.01% +0.05%
==========================================
Files 153 154 +1
Lines 4780 4946 +166
Branches 803 858 +55
==========================================
+ Hits 1193 1237 +44
- Misses 3032 3107 +75
- Partials 555 602 +47
Continue to review full report at Codecov.
|
This was referenced Aug 11, 2017
This was referenced Aug 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] UI Components
Impacts or related to the UI component system
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
General Interface
Parts of the UI which don't fall neatly under other labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes: #839
This pull request seeks to...
Tooltip
componentTooltip
component to renderIconButton
tooltips byaria-label
if no other children are specified (i.e. no explanatory text)Open questions:
Do we want allPrevious iteration of this pull request applied labels to allaria-label
to show as tooltips?Button
. Now we only apply toIconButton
with nochildren
(explanatory text)Testing instructions:
Verify that tooltips show, particularly: