Build Tooling: Restore Playground GitHub Pages deploy #22443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Type] Build Tooling
|
Size Change: 0 B Total Size: 835 kB ℹ️ View Unchanged
|
|
Based on the scrollbar of my browser, I think it worked :p |
|
I can see a new commit: and components added lately like |
|
Nice! Did either of you follow these instructions to "resolve" anything? I didn't take any follow-up action. Perhaps it was already prepared, since we had been using the |
|
I did nothing, I think it just worked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21669
This pull request seeks to attempt to restore the Storybook ("Playground") deployment to GitHub Pages. The version currently available at wordpress.github.io/gutenberg is several weeks out of date at this point, due to the changes in Travis build introduced in the commit at edc4ac6. As discussed in #21669, I have strong reservations against reintroducing personal token-based deployment. This pull request seeks to attempt to use GitHub Actions-based action GitHub Actions for GitHub Pages, using the
github_tokenavailable by default with GitHub Actions.It's not entirely clear if we can expect this to work out of the box, due to the issues with
github_tokendiscussed in #21669 and also summarized as needing special accommodations in the action documentation. The documentation seems to indicate it only requires a "first-time" setup. If this is the case, it's a reasonable compromise to consider.Testing Instructions:
I assume we won't be able to test this except by verifying the results after it's merged 😃