Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Token List: Add type checking #18839

Merged
merged 2 commits into from
Dec 7, 2019
Merged

Token List: Add type checking #18839

merged 2 commits into from
Dec 7, 2019

Conversation

aduth
Copy link
Member

@aduth aduth commented Nov 30, 2019

Part of: #18838

This pull request seeks to enable type checking for the @wordpress/token-list package.

Testing Instructions:

Verify no regressions in modified behavior:

npm run test-unit

Verify types checking passes:

npm run lint:types

@aduth aduth added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Code Quality Issues or PRs that relate to code quality [Package] Token List /packages/token-list labels Nov 30, 2019
@aduth aduth mentioned this pull request Nov 30, 2019
Closed
75 tasks
gziolo
gziolo approved these changes Nov 30, 2019
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, not that much work to get all benefits 👍

packages/token-list/src/index.js Outdated Show resolved Hide resolved
@aduth aduth merged commit 2924efa into master Dec 7, 2019
@aduth aduth deleted the update/token-list-types branch December 7, 2019 21:13
@youknowriad youknowriad added this to the Gutenberg 7.1 milestone Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

Assignees
No one assigned
Labels
[Package] Token List /packages/token-list [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 7.1
Development

Successfully merging this pull request may close these issues.
3 participants
@aduth @gziolo @youknowriad