Custom HTML block: Warning modal is not shown even if there are unsaved changes

[t-hamano]

What problem does this address?

In the custom HTML block, if the modal is closed when there are unsaved changes, a modal should appear and prompt us to choose what action to take.

e25733f2ef534a2d8983af26f356ea2c.mp4

However, I discovered that this feature doesn't work in the first place. This is because if there are unsaved changes, the shouldCloseOnClickOutside prop and shouldCloseOnEsc prop are false, and the onRequestClose event handler doesn't work.

What is your proposed solution?

While this functionality can be restored easily, it feels unnatural since there is no other UI that would display such nested modals in the first place, and I personally think it's fine to remove this modal.

cc @youknowriad @ntsekouras @Mamaduka @jasmussen

[jasmussen]

Good issue, I'd tend to agree with your conclusions. As you note, I wasn't able to close the modal if there are unsaved changes.

An operating system equivalent of "must interact with modal" is to flash the modal when you're clicking outside. Not sure that's necessary here, it seems enough that you can't close the modal until you either choose cancel or update.

[Mamaduka]

What's the reason for preventing modal closing? Mostly to avoid content loss? I don't think we do that in any other modal, which requires confirmation before changing the data.

[jasmussen]

I was only secondarily involved with this one so I can't answer definitively. But I would think, yes, to avoid content loss. Without this, when closing you have to either save what you added (and make the doc dirty), or discard what you added (loss). It's a bit of a unique behavior I agree, but there's also potential to add a lot of stuff inside that modal, under CSS, HTML, and JS tabs. I could also see precedence in other modals; there are a lot of things you can do from anywhere because they happen in a modal, and some might deserve a bit more stickiness so you don't accidentally close and lose your place.

[ntsekouras]

Is there a specific reason not to just update the block (setAttributes) on close?

[t-hamano]

What's the reason for preventing modal closing? Mostly to avoid content loss?

I think so. This block's HTML content is managed in state, so if the modal is closed without pressing the Update button, the changes will be discarded.

Is there a specific reason not to just update the block (setAttributes) on close?

Users may have different preferences as to whether their changes should be saved or discarded when the modal is closed.