Template Parts: Inconsistent replace/edit sidebar views

[bgardner]

Description

While testing #60156, I noticed that there was an inconsistent view/text in the right sidebar.

Step-by-step reproduction instructions

1. Go to Appearance > Editor > Templates > Index in the site editor.
2. Click the Header template part and view sidebar.
3. Click Edit on the Header template part and view sidebar.

Screenshots, screen recording, code snippet

When you complete step #2 above, this is the sidebar:

Then when you complete step #3 above, this is the sidebar:

It seems as though the styling (spacing between icon and Header) and the copy should be consistent.

Below is a video walkthrough of the experience:

Screen.Recording.2024-04-11.at.10.23.11.AM.mov

Environment info

WordPress 6.5.2, Gutenberg 18.1.

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

[colorful-tones]

I almost missed this key distinction on the first pass when reading this:

It seems as though the styling (spacing between icon and Header) and the copy should be consistent.

This is the bug 😄

Template Part block selected	Template Part block in edit mode

[bgardner]

@colorful-tones It is a bug, yes. But... and more importantly, note below that section is not consistent: Design vs. Transform into: (with a paragraph of text below it)

^ this is the part I was trying to emphasize (lack of consistency)

[bgardner]

Per:

[colorful-tones]

Here is the current experience on Gutenberg Trunk c86e77f

template-part-flow-language.mp4

[colorful-tones]

This sent me down a rabbit hole 🕳️ 🐇 of trying to figure out how/why/what/where the overarching changes driving the changes referenced in this bug were stemming from, and I'm still not certain. The pull request Brian references: #60156 suggests it is merely:

Updates the "Replace" label to "Design". Suggested in #59883

and

The designs in #59689 suggest a "Design" panel for this purpose

If one tries to follow the path to the next referenced pull request #59883 they'll find it was closed and explored elsewhere (yet, another pull request):

Thanks for the discussion on this. I am trying a new idea in #60203

So, when you go to #60203, and you find it is merely referencing the previous "exploration" in the previously closed pull request: #59883 🤕

So, I stumbled across this "Proposal" Issue #59970, which seems to be partly tied to maybe what was trying to be addressed by #60156, #59883, and #60203. Hopefully, somebody more privy to what goes on around here can dig in faster with any of this information 💀 🤞