Skip to content

Fixed top toolbar: Bottom border missing in the Site Editor #54093

Closed
@t-hamano

Description

Description

In the Site Editor, when "the top toolbar" feature is activated, the bottom border disappears. This problem does not occur in the submission editor. Nor does it occur when the Gutenberg plugin is disabled.

After a little digging, I found that this bottom border is applied to the header (.edit-site-header-edit-mode) with a height of 40px. The border would disappear because a toolbar with the same 40px height and white background would overlap on top of it.

Step-by-step reproduction instructions

N/A

Screenshots, screen recording, code snippet

site-editor

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

Activity

added
[Type] BugAn existing feature does not function as intended
General InterfaceParts of the UI which don't fall neatly under other labels.
[Type] RegressionRelated to a regression in the latest release
on Aug 31, 2023
ramonjd

ramonjd commented on Sep 3, 2023

@ramonjd
Member

I got something up here: #54131

Not really sure if it's the best fix, but we're a bit constrained by the hard-coded 60px height of the header.

Also noticed the following in all browsers on trunk:

2023-09-03.12.30.00.mp4
moved this from Triage to Needs Dev / Todo in WordPress 6.4 Editor Taskson Sep 8, 2023
moved this from Needs Dev / Todo to In Progress in WordPress 6.4 Editor Taskson Sep 8, 2023
ramonjd

ramonjd commented on Sep 13, 2023

@ramonjd
Member

Resolved by #54356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

General InterfaceParts of the UI which don't fall neatly under other labels.[Status] In ProgressTracking issues with work in progress[Type] BugAn existing feature does not function as intended[Type] RegressionRelated to a regression in the latest release

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Participants

@ramonjd@t-hamano

Issue actions

    Fixed top toolbar: Bottom border missing in the Site Editor · Issue #54093 · WordPress/gutenberg