From 63a6321b88f8adbf69446fea98d45e66015cdbbd Mon Sep 17 00:00:00 2001 From: Andrea Fercia Date: Sat, 30 Dec 2023 08:49:57 +0100 Subject: [PATCH] Fix Template preview menu item accessibility. (#57456) --- .../editor/src/components/post-template/block-theme.js | 3 ++- test/e2e/specs/site-editor/pages.spec.js | 8 ++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/packages/editor/src/components/post-template/block-theme.js b/packages/editor/src/components/post-template/block-theme.js index a8b07cdacb554..dcd269af1a431 100644 --- a/packages/editor/src/components/post-template/block-theme.js +++ b/packages/editor/src/components/post-template/block-theme.js @@ -90,7 +90,8 @@ export default function BlockThemeControl( { id } ) { { setRenderingMode( isTemplateHidden diff --git a/test/e2e/specs/site-editor/pages.spec.js b/test/e2e/specs/site-editor/pages.spec.js index 6de94c3c2d673..a04359730421b 100644 --- a/test/e2e/specs/site-editor/pages.spec.js +++ b/test/e2e/specs/site-editor/pages.spec.js @@ -196,15 +196,15 @@ test.describe( 'Pages', () => { await templateOptionsButton.click(); const templatePreviewButton = page .getByRole( 'menu', { name: 'Template options' } ) - .getByRole( 'menuitem', { name: 'Template preview' } ); + .getByRole( 'menuitemcheckbox', { name: 'Template preview' } ); await expect( templatePreviewButton ).toHaveAttribute( - 'aria-pressed', + 'aria-checked', 'true' ); await templatePreviewButton.click(); await expect( templatePreviewButton ).toHaveAttribute( - 'aria-pressed', + 'aria-checked', 'false' ); @@ -229,7 +229,7 @@ test.describe( 'Pages', () => { await templateOptionsButton.click(); await templatePreviewButton.click(); await expect( templatePreviewButton ).toHaveAttribute( - 'aria-pressed', + 'aria-checked', 'true' );