-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
DataViews: iterate on list view (#56746)
Co-authored-by: James Koster <james@jameskoster.co.uk>
- Loading branch information
1 parent
a66cf2a
commit 40c233f
Showing
11 changed files
with
245 additions
and
64 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,97 @@ | ||
| /** | ||
| * Internal dependencies | ||
| * External dependencies | ||
| */ | ||
| import ViewTable from './view-table'; | ||
| import classNames from 'classnames'; | ||
|
|
||
| export default function ViewList( props ) { | ||
| // To do: change to email-like preview list. | ||
| return <ViewTable { ...props } />; | ||
| /** | ||
| * WordPress dependencies | ||
| */ | ||
| import { useAsyncList } from '@wordpress/compose'; | ||
| import { | ||
| __experimentalHStack as HStack, | ||
| __experimentalVStack as VStack, | ||
| } from '@wordpress/components'; | ||
| import { ENTER, SPACE } from '@wordpress/keycodes'; | ||
|
|
||
| export default function ViewList( { | ||
| view, | ||
| fields, | ||
| data, | ||
| getItemId, | ||
| onSelectionChange, | ||
| selection, | ||
| } ) { | ||
| const shownData = useAsyncList( data, { step: 3 } ); | ||
| const mediaField = fields.find( | ||
| ( field ) => field.id === view.layout.mediaField | ||
| ); | ||
| const primaryField = fields.find( | ||
| ( field ) => field.id === view.layout.primaryField | ||
| ); | ||
| const visibleFields = fields.filter( | ||
| ( field ) => | ||
| ! view.hiddenFields.includes( field.id ) && | ||
| ! [ view.layout.primaryField, view.layout.mediaField ].includes( | ||
| field.id | ||
| ) | ||
| ); | ||
|
|
||
| const onEnter = ( item ) => ( event ) => { | ||
| const { keyCode } = event; | ||
| if ( [ ENTER, SPACE ].includes( keyCode ) ) { | ||
| onSelectionChange( [ item ] ); | ||
| } | ||
| }; | ||
|
|
||
| return ( | ||
| <ul className="dataviews-list-view"> | ||
| { shownData.map( ( item, index ) => { | ||
| return ( | ||
| <li key={ getItemId?.( item ) || index }> | ||
| <div | ||
| role="button" | ||
| tabIndex={ 0 } | ||
| aria-pressed={ selection.includes( item.id ) } | ||
| onKeyDown={ onEnter( item ) } | ||
| className={ classNames( | ||
| 'dataviews-list-view__item', | ||
| { | ||
| 'dataviews-list-view__item-selected': | ||
| selection.includes( item.id ), | ||
| } | ||
| ) } | ||
| onClick={ () => onSelectionChange( [ item ] ) } | ||
| > | ||
| <HStack spacing={ 3 }> | ||
| <div className="dataviews-list-view__media-wrapper"> | ||
| { mediaField?.render( { item } ) || ( | ||
| <div className="dataviews-list-view__media-placeholder"></div> | ||
| ) } | ||
| </div> | ||
| <HStack> | ||
| <VStack spacing={ 1 }> | ||
| { primaryField?.render( { item } ) } | ||
| <div className="dataviews-list-view__fields"> | ||
| { visibleFields.map( ( field ) => { | ||
| return ( | ||
| <span | ||
| key={ field.id } | ||
| className="dataviews-list-view__field" | ||
| > | ||
| { field.render( { | ||
| item, | ||
| } ) } | ||
| </span> | ||
| ); | ||
| } ) } | ||
| </div> | ||
| </VStack> | ||
| </HStack> | ||
| </HStack> | ||
| </div> | ||
| </li> | ||
| ); | ||
| } ) } | ||
| </ul> | ||
| ); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
40c233fThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flaky tests detected in 40c233f.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7126053932
📝 Reported issues:
/test/e2e/specs/site-editor/font-library.spec.js