From 21818236f0db9167541a6fd2f3a1ff638b71e89f Mon Sep 17 00:00:00 2001 From: Daniel Richards Date: Fri, 29 May 2020 10:47:02 +0800 Subject: [PATCH] Disable inconsistent gallery end-to-end test (#22726) * Disable flakey gallery test * Remove non-functioning media modal exceptions --- packages/e2e-tests/config/setup-test-framework.js | 4 ---- .../e2e-tests/specs/editor/blocks/gallery.test.js | 13 ++++++++++++- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/packages/e2e-tests/config/setup-test-framework.js b/packages/e2e-tests/config/setup-test-framework.js index 56f33cbb34880b..98cc0a5f2657f8 100644 --- a/packages/e2e-tests/config/setup-test-framework.js +++ b/packages/e2e-tests/config/setup-test-framework.js @@ -245,10 +245,6 @@ async function runAxeTestsForBlockEditor() { '.edit-post-layout__metaboxes', // Ignores elements created by TinyMCE. '.mce-container', - // Ignores elements within the media modal. - // Related: https://core.trac.wordpress.org/ticket/50273 - '.media-modal', - '.media-modal .attachment', // These properties were not included in the 1.1 spec // through error, they should be allowed on role="row": // https://github.com/w3c/aria/issues/558 diff --git a/packages/e2e-tests/specs/editor/blocks/gallery.test.js b/packages/e2e-tests/specs/editor/blocks/gallery.test.js index 617e9746670699..8db6bfe60a2bea 100644 --- a/packages/e2e-tests/specs/editor/blocks/gallery.test.js +++ b/packages/e2e-tests/specs/editor/blocks/gallery.test.js @@ -52,7 +52,18 @@ describe( 'Gallery', () => { expect( await getEditedPostContent() ).toMatch( regex ); } ); - it( 'when initially added the media library shows the Create Gallery view', async () => { + // Disable reason: + // This test would be good to enable, but the media modal contains an + // invalid role, which is causing Axe tests to fail: + // https://core.trac.wordpress.org/ticket/50273 + // + // Attempts to add an Axe exception for the media modal haven't proved + // successful: + // https://github.com/WordPress/gutenberg/pull/22719 + // + // This test could be re-enabled once the trac ticket is solved. + // eslint-disable-next-line jest/no-disabled-tests + it.skip( 'when initially added the media library shows the Create Gallery view', async () => { await insertBlock( 'Gallery' ); await clickButton( 'Media Library' ); await page.waitForSelector( '.media-frame' );