Skip to content

Commit 7c52445

Browse files
committed
fix: android build
1 parent 8c16952 commit 7c52445

File tree

5 files changed

+7
-31
lines changed

5 files changed

+7
-31
lines changed

android/build.gradle

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,5 @@ android {
3030

3131
dependencies {
3232
implementation project(':openCVLibrary310')
33-
implementation 'com.android.support:appcompat-v7:26.1.0'
34-
implementation 'com.facebook.react:react-native:0.19.+'
33+
implementation 'com.facebook.react:react-native:+'
3534
}

android/src/main/java/com/documentscanner/DocumentScannerModule.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,9 @@
44
import com.facebook.react.bridge.ReactApplicationContext;
55
import com.facebook.react.bridge.ReactContextBaseJavaModule;
66
import com.facebook.react.bridge.ReactMethod;
7-
8-
/**
9-
* Created by andre on 28/11/2017.
10-
*/
7+
import com.facebook.react.uimanager.NativeViewHierarchyManager;
8+
import com.facebook.react.uimanager.UIBlock;
9+
import com.facebook.react.uimanager.UIManagerModule;
1110

1211
public class DocumentScannerModule extends ReactContextBaseJavaModule{
1312

android/src/main/java/com/documentscanner/DocumentScannerPackage.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,6 @@
1010
import java.util.Collections;
1111
import java.util.List;
1212

13-
/**
14-
* Created by andre on 28/11/2017.
15-
*/
16-
1713
public class DocumentScannerPackage implements ReactPackage {
1814

1915

@@ -24,7 +20,7 @@ public List<NativeModule> createNativeModules(ReactApplicationContext reactConte
2420
);
2521
}
2622

27-
@Override
23+
// Deprecated in RN 0.47
2824
public List<Class<? extends JavaScriptModule>> createJSModules() {
2925
return Collections.emptyList();
3026
}

android/src/main/java/com/documentscanner/DocumentScannerViewManager.java

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,6 @@
1313

1414
import javax.annotation.Nullable;
1515

16-
/**
17-
* Created by Andre on 29/11/2017.
18-
*/
19-
2016
public class DocumentScannerViewManager extends ViewGroupManager<MainView> {
2117

2218
private static final String REACT_CLASS = "RNPdfScanner";
@@ -29,11 +25,7 @@ public String getName() {
2925

3026
@Override
3127
protected MainView createViewInstance(final ThemedReactContext reactContext) {
32-
// OpenNoteCameraView view = new OpenNoteCameraView(reactContext, -1,
33-
// reactContext.getCurrentActivity());
34-
MainView.createInstance(reactContext, (Activity) reactContext.getBaseContext());
35-
36-
view = MainView.getInstance();
28+
view = new MainView(reactContext, (Activity) reactContext.getBaseContext());
3729
view.setOnProcessingListener(new OpenNoteCameraView.OnProcessingListener() {
3830
@Override
3931
public void onProcessingChange(WritableMap data) {

android/src/main/java/com/documentscanner/views/MainView.java

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -14,17 +14,7 @@
1414
public class MainView extends FrameLayout {
1515
private OpenNoteCameraView view;
1616

17-
public static MainView instance = null;
18-
19-
public static MainView getInstance() {
20-
return instance;
21-
}
22-
23-
public static void createInstance(Context context, Activity activity) {
24-
instance = new MainView(context, activity);
25-
}
26-
27-
private MainView(Context context, Activity activity) {
17+
public MainView(Context context, Activity activity) {
2818
super(context);
2919

3020
LayoutInflater lf = (LayoutInflater) context.getSystemService(Context.LAYOUT_INFLATER_SERVICE);

0 commit comments

Comments
 (0)