Add a convenience initializer that takes a variadic list of elements #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -98,6 +98,10 @@ public final class ReactiveArray<T>: CollectionType, MutableCollectionType, Debu | |||
| self.init(elements: []) | |||
| } | |||
|
|
|||
| public convenience init(_ elements: T...) { | |||
|
Sorry for the delayed response last week has been crazy for me. I agree that having to specify the type when using the convenience initializer is dumb but it might be fixed in future versions of the compiler. Could you add a test case for this initializer? Thanks for contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8 . Unfortunately the compiler can't infer the element type in this case so you have to do
ReactiveArray<Int>(1, 2, 3, 4). I'd actually say not to merge this, since manually specifying the type is dumb, but I felt like getting my feet wet with those awesome-looking project!