feat: proper snapshot when having multiple modals (software-mansion#2121)

WoLewicki · ja1ns · commit 43d0090a0b08 · 2024-10-09T16:39:00.000+05:30
PR handling setting a proper snapshot of a modal when it is dismissed from JS on new arch. Still does not work with Test1829
diff --git a/ios/RNSScreenStack.mm b/ios/RNSScreenStack.mm
@@ -1175,7 +1175,11 @@ - (void)unmountChildComponentView:(UIView<RCTComponentViewProtocol> *)childCompo
 
 - (void)takeSnapshot
 {
-  _snapshot = [_controller.visibleViewController.view snapshotViewAfterScreenUpdates:NO];
+  if (_presentedModals.count < 2) {
+    _snapshot = [_controller.visibleViewController.view snapshotViewAfterScreenUpdates:NO];
+  } else {
+    _snapshot = [[_presentedModals.lastObject view] snapshotViewAfterScreenUpdates:NO];
+  }
 }
 
 - (void)mountingTransactionWillMount:(react::MountingTransaction const &)transaction

Original file line number	Diff line number	Diff line change
`@@ -1175,7 +1175,11 @@ - (void)unmountChildComponentView:(UIView<RCTComponentViewProtocol> *)childCompo`
`1175`	`1175`
`1176`	`1176`	`- (void)takeSnapshot`
`1177`	`1177`	`{`
`1178`		`- _snapshot = [_controller.visibleViewController.view snapshotViewAfterScreenUpdates:NO];`
	`1178`	`+ if (_presentedModals.count < 2) {`
	`1179`	`+ _snapshot = [_controller.visibleViewController.view snapshotViewAfterScreenUpdates:NO];`
	`1180`	`+ } else {`
	`1181`	`+ _snapshot = [[_presentedModals.lastObject view] snapshotViewAfterScreenUpdates:NO];`
	`1182`	`+ }`
`1179`	`1183`	`}`
`1180`	`1184`
`1181`	`1185`	`- (void)mountingTransactionWillMount:(react::MountingTransaction const &)transaction`