Fix code scanning alert no. 3: User-controlled data in arithmetic expression #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ression Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/Wintellisys/MachineLearningNotebooks/security/code-scanning/3
To fix the problem, we need to validate the
resetvalue before performing the arithmetic operation. Specifically, we should ensure thatresetis greater than 0 before subtracting 1 from it. Ifresetis 0 or negative, we should handle it appropriately to avoid underflow.The best way to fix this without changing existing functionality is to add a check for
resetbefore performing the subtraction. Ifresetis less than or equal to 0, we can setpreviousTokento a default value or handle it in a way that makes sense for the application.Suggested fixes powered by Copilot Autofix. Review carefully before merging.