Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

segmentation_B discrepancies #240

Open
cpaniaguam opened this issue Mar 9, 2023 · 2 comments
Open

segmentation_B discrepancies #240

cpaniaguam opened this issue Mar 9, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@cpaniaguam
Copy link
Member

@tdivoll
Comparing the workflow for segF against that in the test file, I am getting significant differences between inputs segB.ice_intersect (workflow) and segmentation_B_ice_intersect (read in for testing).

Here is the input image used in the ci tests for segmentation_F.jl segmentation_B_ice_intersect
image

And here is what I get via the full workflow for segB.ice_intersect
image

Originally posted by @cpaniaguam in #239 (comment)

@cpaniaguam cpaniaguam added the bug Something isn't working label Mar 9, 2023
@cpaniaguam
Copy link
Member Author

I am also seeing differences in segB.not_ice. They look like they are inverted versions of each other.
From the workflow
download
From ci tests
download

If I do a complement + landmask, I get a match with about 10% error.

@tdivoll
Copy link
Collaborator

tdivoll commented Mar 13, 2023

Hoping this is fixed by #241, let's check the CI there and then use the updated segmentation_b and segmentation_watershed functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants