Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dns command to handle missing DNS entries #12

Open
BigBlueHat opened this issue Mar 7, 2022 · 1 comment
Open

Fix dns command to handle missing DNS entries #12

BigBlueHat opened this issue Mar 7, 2022 · 1 comment

Comments

@BigBlueHat
Copy link
Contributor

BigBlueHat commented Mar 7, 2022 •
edited
Loading

Right now it assumes missing DNS records are "conflicts" and tries to delete them (which fails...) prior to adding them (which would've worked just fine except for the earlier failure...).

hasConflictingDNSRecord likely needs reconsidering, but certainly its use in the dns command.
@BigBlueHat
Copy link
Contributor Author

We should also add a dns: section to the YAML for cases where these zones do more than redirect (i.e. MX records, etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BigBlueHat