Tests: stop autoloading with the rest of the production build #680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anomiex
reviewed
Mar 23, 2023
NielsLeenheer
approved these changes
Apr 16, 2024
Member
NielsLeenheer
left a comment
NielsLeenheer
left a comment
There was a problem hiding this comment.
Took a long time to get back to WhichBrowser, but thanks for this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #679
Changes suggested in this Pull Request
Instead of autoloading the tests by default (they do not get shipped with the production version of the package), let's bootstrap them separately, just for the tests.
To do
This breaksThis was fixed in 77a681dbin/runner.php. I am not familiar with this repo so I do not know how this is used. I'll let someone else who is more comfortable with this repository make suggestions :)