fix: better syncing, less work

Author: feildmaster

app/src/main/java/tech/akpmakes/android/taskkeeper/TaskViewActivity.java

@@ -27,7 +27,7 @@
 import tech.akpmakes.android.taskkeeper.models.WhenEvent;
 
 public class TaskViewActivity extends AppCompatActivity implements DatePickerDialog.OnDateSetListener, TimePickerDialog.OnTimeSetListener {
-    Calendar whenTime;
+    final Calendar whenTime = Calendar.getInstance();
     EditText taskName;
     TextView taskDate;
     TextView taskTime;
@@ -43,8 +43,6 @@ protected void onCreate(Bundle savedInstanceState) {
         taskTime = findViewById(R.id.task_when_time);
         useCurrentTime = findViewById(R.id.useCurrentTime);
 
-        whenTime = Calendar.getInstance();
-
         final Handler handler = new Handler();
         handler.postDelayed(new Runnable() {
             @Override
@@ -75,10 +73,7 @@ public void run() {
         taskDate.setOnClickListener(new View.OnClickListener() {
             @Override
             public void onClick(View view) {
-                Calendar now = Calendar.getInstance();
-                if(whenTime != null) {
-                    now = whenTime;
-                }
+                Calendar now = whenTime;
                 DatePickerDialog datePicker = DatePickerDialog.newInstance(
                         TaskViewActivity.this,
                         now.get(Calendar.YEAR),
@@ -91,10 +86,7 @@ public void onClick(View view) {
         taskTime.setOnClickListener(new View.OnClickListener() {
             @Override
             public void onClick(View view) {
-                Calendar now = Calendar.getInstance();
-                if(whenTime != null) {
-                    now = whenTime;
-                }
+                Calendar now = whenTime;
                 TimePickerDialog timePicker = TimePickerDialog.newInstance(
                         TaskViewActivity.this,
                         now.get(Calendar.HOUR_OF_DAY),
@@ -119,7 +111,7 @@ private void saveTask() {
             updateTime();
         }
         String name = taskName.getText().toString();
-        Long when = whenTime.getTimeInMillis();
+        long when = whenTime.getTimeInMillis();
         if (name.length() == 0) {
             taskName.setError("Task name is required!");
             return;
@@ -176,7 +168,7 @@ public void onTimeSet(TimePickerDialog view, int hourOfDay, int minute, int seco
     }
 
     private void updateTime() {
-        whenTime = Calendar.getInstance();
+        whenTime.setTimeInMillis(System.currentTimeMillis());
         updateDateTimeUI();
     }
 

app/src/main/java/tech/akpmakes/android/taskkeeper/firebase/WhenEventViewHolder.java

@@ -48,11 +48,12 @@ private long delay() {
     }
 
     private void draw() {
+        final long now = System.currentTimeMillis();
         String extra = "";
-        if(this.when > new Date().getTime()) {
+        if(this.when > now) {
             extra = "+";
         }
-        this.whenText.setText(millisToShortDHMS(new Date().getTime() - this.when, extra));
+        this.whenText.setText(millisToShortDHMS(now - this.when, extra));
     }
 
     public void setName(String name) {