New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read file only once #238

Open

awalterschulze opened this issue Jan 18, 2021 · 0 comments · May be fixed by #346

Labels

enhancement help wanted

Member

awalterschulze commented Jan 18, 2021

#235 reads the file twice, but fixes an important issue to not write a file that has not been modified.

Possibly lets always read in the whole file as a string before sending it to the scanner, then it is available for comparison after formatting.

This should simplify a lot of the code and get rid of the file scanner.

awalterschulze added the enhancement label

awalterschulze mentioned this issue

Only write to file the formatted code when it is different to the current one #235

Merged

awalterschulze added the help wanted label

jdamanalo linked a pull request

that will close this issue

Read input only once #346

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment