Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

has:variant should always search for string(s) that have variant(s) in the language in which the user is searching #12825

Open
2 tasks done
Geeyun-JY3 opened this issue Oct 20, 2024 · 3 comments
Assignees
Labels
bug Something is broken.
Milestone

Comments

@Geeyun-JY3
Copy link
Collaborator

Geeyun-JY3 commented Oct 20, 2024

Describe the issue

Currently, has:variant would search for string(s) that have variant(s) in any one of languages, rather than in the language in which the user is searching. This may confuse the user.

And there is a redundant Things to check panel with nothing but a title in the full editor, while the current string has no variant in the current language, but has variants in other languages.

I already tried

  • I've read and searched the documentation.
  • I've searched for similar filed issues in this repository.

Steps to reproduce the behavior

  1. Go to the search page of a language
  2. Enter has:variant
  3. Find a string that has variants that are not in the current language

Expected behavior

has:variant should always search for string(s) that have variant(s) in the language in which the user is searching, rather than in any one of languages.

Screenshots

Example:
a string that has no variant in Chinese (Simplified Han script):
image
(And there is a redundant Things to check panel with nothing but a title.)
but has variants in English:
image
and Estonian:
image

Exception traceback

No response

How do you run Weblate?

weblate.org service

Weblate versions

5.8.2-dev

Weblate deploy checks

No response

Additional context

No response

@nijel nijel added the bug Something is broken. label Oct 21, 2024
@nijel nijel added this to the 5.9 milestone Oct 21, 2024
@gersona
Copy link
Collaborator

gersona commented Nov 12, 2024

@Geeyun-JY3 could you share more details about how the variants were added (manually, via the regular expression or with a tag)?

@Geeyun-JY3
Copy link
Collaborator Author

I did not add the variants mentioned above. But they are obviously added manually.

@nijel
Copy link
Member

nijel commented Nov 12, 2024

@gersona These are manually added, can be seen here:

The variant is IMHO always added in the source language, but the translation for those doesn't have to exist (what is the case here).

@Geeyun-JY3 It would be useful to include such a link in the report as it's not obvious to everybody where to find that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken.
Projects
None yet
Development

No branches or pull requests

3 participants