Recursive handling of stdClass in response #577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced char-by-char retrieval from stream via fread() with fgets() to get full line from stream until EOF or newline. This speeds up data transfer by factor 10.
Reading whole lines from stream
For example, calling overview() on a folder using LegacyProcotol (i.e. POP3) can result in error "Object of class stdClass could not be converted to string", because response might contain stdClass object which is not yet handled recursively by verify_data().
When IMAP C-extension for PHP is missing, MIME-encoded header fields aren't decoded correctly.
Have to investigate first, why tests fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, calling
overview()on a folder usingLegacyProcotol(i.e. POP3) can result in errorError: Object of class stdClass could not be converted to string in /path/to/code/webklex/php-imap/src/Connection/Protocols/Response.php:365, because response might containstdClassobject which is not yet handled recursively byverify_data().Because
stdClassis handled in a similar way like arrays in PHP, we can simply add check for$data instanceof stdClassto IF-clause inverify_data()and recursive processing is done by existing code then.