Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule screen should draw placeholder for invalid missing things #1654

Open
dhylands opened this issue Feb 14, 2019 · 4 comments
Open

Rule screen should draw placeholder for invalid missing things #1654

dhylands opened this issue Feb 14, 2019 · 4 comments

Comments

@dhylands
Copy link
Contributor

I had to reboot my WifiAccess Point and my Sonos speakers got different IP addresses.

Which means I could no longer control them. So I had to remove and re-add each speaker.

This in turn invalidated all the rules which referenced the speaker.

When I went to edit the rules, the old speaker things were completely gone, so I needed to remember which speakers were used as inputs (so I could tell if they were currently playing or not) and which ones were used as outputs.

It would be better if the invalid thing were still visible somehow to act a reminder of what was invalid.

@mrstegeman
Copy link
Contributor

mrstegeman commented Feb 14, 2019

@freaktechnik Tangentially related... are the Sonos speakers assigned IDs based on their IP addresses?

@dhylands
Copy link
Contributor Author

The ID is the IP address.

@freaktechnik
Copy link
Contributor

@hobinjk
Copy link
Contributor

hobinjk commented Feb 14, 2019

The rules engine keeps enough information around to draw a barebones UI element. I could also allow it to store/create invalid rules. It should be relatively straightforward

@hobinjk hobinjk changed the title Rules engine issues Rule screen should draw placeholder for invalid missing things Feb 14, 2019
@hobinjk hobinjk self-assigned this Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants