Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With 24 things, finding things in rules engine is a pain #1634

Open
dhylands opened this issue Feb 5, 2019 · 11 comments
Open

With 24 things, finding things in rules engine is a pain #1634

dhylands opened this issue Feb 5, 2019 · 11 comments

Comments

@dhylands
Copy link
Contributor

dhylands commented Feb 5, 2019

I currently only have 24 things, but trying to find the one I want by scrolling horizontally, especially since you can't always read the entire label, seems problematic.

@dhylands
Copy link
Contributor Author

dhylands commented Feb 5, 2019

This is for adding/creating rules

@benfrancis
Copy link
Member

"only"

@hobinjk
Copy link
Contributor

hobinjk commented Feb 6, 2019

What are the labels you're having trouble with? I tried getting a label to cut off but it only increased the height of the thing drawer.

@hobinjk
Copy link
Contributor

hobinjk commented Feb 6, 2019

I think a good first step for this would be to alphabetize the things in the drawer since right now they're in API order which is a bit random

@mrstegeman
Copy link
Contributor

@hobinjk After we get #1638 merged, things will be in the same order they are on the Things page, which is user defined.

@flatsiedatsie
Copy link
Contributor

flatsiedatsie commented Feb 7, 2019

I created the proposal to have sentence-based rules elsewhere. This example builds on that. But in any case, I imagine users could filter their rules based on which devices or properties they apply to. In this example they could use voice input to filter the rules. E.g. "Mozilla, show rules with the clock":

mozilla-gateway-rules-overview

A user could then perhaps say "Mozilla, remove the first rule shown".

The could also use voice input as a way to generate (the scaffolding for) a new rule. Or they could click together the sentences.
textual_rules
For example, if the user clicks on "And ..." they can select any existing device. Once it's selected, they can fine-tune the sentence which it generates. If a thing has multiple properties, users must first select that property before they can fine tune that property.

See also: #1418

@dhylands
Copy link
Contributor Author

dhylands commented Feb 7, 2019

What are the labels you're having trouble with? I tried getting a label to cut off but it only increased the height of the thing drawer.

When I have a several nodes with names like zb-0000000000000000-button (so there are 16 digits) right beside each other the labels from one device run into the next one. I'm not at home right now, and that's where my computer than displayed it this way is, so I'll have to grab a screen shot next week.

@dhylands
Copy link
Contributor Author

dhylands commented Feb 7, 2019

I was able to reproduce it here:
rules

Well almost. On my computer at home, I think that the last digit or so of one labels gets overwritten by the label next to it. On the main screen, the last digit gets chopped in half.

@dhylands
Copy link
Contributor Author

It seems to have the problem under firefox (running 65).
rules-ff

It looks like all of the digits are actually visible and the dash is overwriting the label of the next thing.

and the same thing under Chrome
rules-chrome

@flatsiedatsie
Copy link
Contributor

flatsiedatsie commented Feb 25, 2021

rule_scrollable_drawer

An experiment for the Square theme. This modification would only be made on high-res screens, which are unlikely to be touch screens.

I tried making a vertical thing drawer on the left of the screen, so that scrolling would be more intuitive, but then the javascript didn't seem to work properly anymore. The vertical split, where the bottom half is the tray, seems to be hard coded.

rules_side_tray
Not currently possible

@kgiori
Copy link
Contributor

kgiori commented Feb 26, 2021

Having multiple scrollable rows of things would be faster to find what you're looking for than a single row. But as you note, it wouldn't work on a mobile device, and might be too thick on a tablet too. But if you could detect the form factor, and it fits, it would be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants