Switching rule from SetEffect to PulseEffect doesn't preserve previous property state

[benfrancis]

STR:

• Add virtual on/off switch
• Add virtual on/off light
• Add virtual on/off color light
• Create a rule that says "If virtual on/off switch is on and virtual on/off light is on, turn virtual on/off color light on"
• Navigate to things screen
• Trigger rule by turning on/off switch and on/off light on
• Navigate to Rules screen and modify rule from "if" to "while"
• Turn virtual on/off light off

Expected:

• Virtual on/off color light turns off

Actual:

• Virtual on/off color light stays lit until it is manually turned off, then the while rule starts working.

[hobinjk]

Looking into this the problem is that the rule completely resets its state whenever modified. For example, setting up "While door is open turn light to red", opening the door, modifying the color to blue, then closing the door will not reset the color to its original state.

I started working on a fix but it's proving a bit hard to work out.