-
Notifications
You must be signed in to change notification settings - Fork 3
Add buildbot-worker documentation #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
79ed59b to
f38c4c9
Compare
37886bd to
1669c27
Compare
BUILDBOT.md
Outdated
|
|
||
| > [!IMPORTANT] | ||
| > To connect to WebKit infrastructure credentials are required. | ||
| > Contact the infrastructure team on [Slack](https://webkit.slack.com) for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a specific group or anything for this? People might be a problem with changing, but it might be hard for someone to know who to ask for just infrastructure team.
BUILDBOT.md
Outdated
|
|
||
| | Environment Variable | Required | Description | | ||
| |---|:---:|---| | ||
| | BUILD_HOST_NAME | :white_check_mark: | Host of the buildbot instance, either `build.webkit.org` or `ews-build.webkit.org` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's kind of obvious, but probably we need to explain how to choose this for people with less general understanding of the overall setup.
BUILDBOT.md
Outdated
| | ADMIN_NAME | :x:| Contact name for the admin of the worker | | ||
| | ADMIN_EMAIL | :x: | Contact e-mail address for the admin of the worker | | ||
| | HOST_DESCRIPTION |:x: | A description of the host running the worker | | ||
| | COMPILER | :x: | Set this to `Clang` to use `clang-cl`, defaults to `cl` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably need to explain that our bots are using Clang or at least that we recommend/require Clang. Because this doesn't really help anyone make the decision of whether to set it or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was written before the Clang takeover so I think this just needs to be removed and Clang needs to be the way
BUILDBOT.md
Outdated
| gives it access to all the resources of the host. | ||
|
|
||
| ```powershell | ||
| docker run --name build --env-file build.env --detach --restart always webkitdev/buildbot-worker:2022 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tag connection is a bit tenuous here, with the docs like this I'd expect people to end up using this even on a layout tester and then have trouble figuring out why it's failing.
a4aef8b to
b23c3d4
Compare
Create documentation on how to connect a `buildbot-worker` container to WebKit infrastructure.
b23c3d4 to
21dac56
Compare
Create documentation on how to connect a
buildbot-workercontainer to WebKit infrastructcure.