Skip to content

Conversation

@donny-dont
Copy link
Collaborator

Create documentation on how to connect a buildbot-worker container to WebKit infrastructcure.

@donny-dont donny-dont force-pushed the buildbot-docs branch 3 times, most recently from 37886bd to 1669c27 Compare July 10, 2024 18:01
BUILDBOT.md Outdated

> [!IMPORTANT]
> To connect to WebKit infrastructure credentials are required.
> Contact the infrastructure team on [Slack](https://webkit.slack.com) for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific group or anything for this? People might be a problem with changing, but it might be hard for someone to know who to ask for just infrastructure team.

BUILDBOT.md Outdated

| Environment Variable | Required | Description |
|---|:---:|---|
| BUILD_HOST_NAME | :white_check_mark: | Host of the buildbot instance, either `build.webkit.org` or `ews-build.webkit.org` |
Copy link
Contributor

@foopoiuyt foopoiuyt Jul 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's kind of obvious, but probably we need to explain how to choose this for people with less general understanding of the overall setup.

BUILDBOT.md Outdated
| ADMIN_NAME | :x:| Contact name for the admin of the worker |
| ADMIN_EMAIL | :x: | Contact e-mail address for the admin of the worker |
| HOST_DESCRIPTION |:x: | A description of the host running the worker |
| COMPILER | :x: | Set this to `Clang` to use `clang-cl`, defaults to `cl` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need to explain that our bots are using Clang or at least that we recommend/require Clang. Because this doesn't really help anyone make the decision of whether to set it or not.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was written before the Clang takeover so I think this just needs to be removed and Clang needs to be the way

BUILDBOT.md Outdated
gives it access to all the resources of the host.

```powershell
docker run --name build --env-file build.env --detach --restart always webkitdev/buildbot-worker:2022
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tag connection is a bit tenuous here, with the docs like this I'd expect people to end up using this even on a layout tester and then have trouble figuring out why it's failing.

@donny-dont donny-dont force-pushed the buildbot-docs branch 2 times, most recently from a4aef8b to b23c3d4 Compare September 17, 2024 21:46
Create documentation on how to connect a `buildbot-worker` container to WebKit infrastructure.
@donny-dont donny-dont merged commit 1480a89 into main Sep 17, 2024
@donny-dont donny-dont deleted the buildbot-docs branch September 17, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants